| Message ID | 20221223233200.26089-15-quic_wcheng@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce QC USB SND audio offloading support | expand |
On 24/12/2022 00:32, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > index 70080d04ddc9..60cd84e6727a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml > @@ -216,6 +216,19 @@ examples: > sound-dai = <&vamacro 0>; > }; > }; > + > + usb-dai-link { > + link-name = "USB Playback"; > + cpu { > + sound-dai = <&q6afedai USB_RX>; Hmm, that makes me wonder if you really tested the bindings before sending? If yes, where is the USB_RX defined? Best regards, Krzysztof
On Mon, Dec 26, 2022 at 01:27:21PM +0100, Krzysztof Kozlowski wrote: > On 24/12/2022 00:32, Wesley Cheng wrote: > > + link-name = "USB Playback"; > > + cpu { > > + sound-dai = <&q6afedai USB_RX>; > Hmm, that makes me wonder if you really tested the bindings before > sending? If yes, where is the USB_RX defined? It was added in patch 2, it's in include/dt-bindings.
On Fri, 23 Dec 2022 15:32:00 -0800, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On 03/01/2023 18:46, Mark Brown wrote: > On Mon, Dec 26, 2022 at 01:27:21PM +0100, Krzysztof Kozlowski wrote: >> On 24/12/2022 00:32, Wesley Cheng wrote: > >>> + link-name = "USB Playback"; >>> + cpu { >>> + sound-dai = <&q6afedai USB_RX>; > >> Hmm, that makes me wonder if you really tested the bindings before >> sending? If yes, where is the USB_RX defined? > > It was added in patch 2, it's in include/dt-bindings. Thanks, indeed, I was looking for another bindings patch but this was squashed with a driver. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 70080d04ddc9..60cd84e6727a 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -216,6 +216,19 @@ examples: sound-dai = <&vamacro 0>; }; }; + + usb-dai-link { + link-name = "USB Playback"; + cpu { + sound-dai = <&q6afedai USB_RX>; + }; + codec { + sound-dai = <&usbdai USB_RX>; + }; + platform { + sound-dai = <&q6routing>; + }; + }; }; - |
Add an example on enabling of USB offload for the Q6DSP. The routing can be done by the mixer, which can pass the multimedia stream to the USB backend. Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> --- .../devicetree/bindings/sound/qcom,sm8250.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)