| Message ID | 20230106114403.275865-4-matti.lehtimaki@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | General Purpose clocks and matisse-wifi backlight | expand |
On 6.01.2023 12:44, Matti Lehtimäki wrote: > Uses ti,lp8556 backlight with clk-pwm. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > index 15b9590ba07b..848cfda64e5a 100644 > --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts > @@ -23,6 +23,14 @@ aliases { > display0 = &framebuffer0; > }; > > + backlight_pwm: pwm { This should be sorted alphabetically. > + compatible = "clk-pwm"; > + #pwm-cells = <2>; > + clocks = <&mmcc CAMSS_GP0_CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&backlight_pwm_default_state>; > + }; > + > chosen { > #address-cells = <1>; > #size-cells = <1>; > @@ -80,6 +88,45 @@ key-volume-up { > }; > }; > > + i2c-backlight { > + compatible = "i2c-gpio"; > + sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&backlight_i2c_default_state>; Please reorder these two properties. > + > + i2c-gpio,delay-us = <4>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + backlight@2c { > + compatible = "ti,lp8556"; > + reg = <0x2c>; > + > + dev-ctrl = /bits/ 8 <0x80>; > + init-brt = /bits/ 8 <0x3f>; > + pwm-period = <100000>; > + > + pwms = <&backlight_pwm 0 100000>; > + pwm-names = "lp8556"; > + > + rom-a0h { > + rom-addr = /bits/ 8 <0xa0>; > + rom-val = /bits/ 8 <0x44>; > + }; Please add a newline between each subnode. Otherwise I think this looks good.. Konrad > + rom-a1h { > + rom-addr = /bits/ 8 <0xa1>; > + rom-val = /bits/ 8 <0x6c>; > + }; > + rom-a5h { > + rom-addr = /bits/ 8 <0xa5>; > + rom-val = /bits/ 8 <0x24>; > + }; > + }; > + }; > + > reg_tsp_1p8v: regulator-tsp-1p8v { > compatible = "regulator-fixed"; > regulator-name = "tsp_1p8v"; > @@ -418,6 +465,18 @@ accel_int_default_state: accel-int-default-state { > bias-disable; > }; > > + backlight_i2c_default_state: backlight-i2c-default-state { > + pins = "gpio20", "gpio21"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + backlight_pwm_default_state: backlight-pwm-default-state { > + pins = "gpio33"; > + function = "gp0_clk"; > + }; > + > muic_int_default_state: muic-int-default-state { > pins = "gpio67"; > function = "gpio";
diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts index 15b9590ba07b..848cfda64e5a 100644 --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts @@ -23,6 +23,14 @@ aliases { display0 = &framebuffer0; }; + backlight_pwm: pwm { + compatible = "clk-pwm"; + #pwm-cells = <2>; + clocks = <&mmcc CAMSS_GP0_CLK>; + pinctrl-names = "default"; + pinctrl-0 = <&backlight_pwm_default_state>; + }; + chosen { #address-cells = <1>; #size-cells = <1>; @@ -80,6 +88,45 @@ key-volume-up { }; }; + i2c-backlight { + compatible = "i2c-gpio"; + sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + + pinctrl-names = "default"; + pinctrl-0 = <&backlight_i2c_default_state>; + + i2c-gpio,delay-us = <4>; + + #address-cells = <1>; + #size-cells = <0>; + + backlight@2c { + compatible = "ti,lp8556"; + reg = <0x2c>; + + dev-ctrl = /bits/ 8 <0x80>; + init-brt = /bits/ 8 <0x3f>; + pwm-period = <100000>; + + pwms = <&backlight_pwm 0 100000>; + pwm-names = "lp8556"; + + rom-a0h { + rom-addr = /bits/ 8 <0xa0>; + rom-val = /bits/ 8 <0x44>; + }; + rom-a1h { + rom-addr = /bits/ 8 <0xa1>; + rom-val = /bits/ 8 <0x6c>; + }; + rom-a5h { + rom-addr = /bits/ 8 <0xa5>; + rom-val = /bits/ 8 <0x24>; + }; + }; + }; + reg_tsp_1p8v: regulator-tsp-1p8v { compatible = "regulator-fixed"; regulator-name = "tsp_1p8v"; @@ -418,6 +465,18 @@ accel_int_default_state: accel-int-default-state { bias-disable; }; + backlight_i2c_default_state: backlight-i2c-default-state { + pins = "gpio20", "gpio21"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + backlight_pwm_default_state: backlight-pwm-default-state { + pins = "gpio33"; + function = "gp0_clk"; + }; + muic_int_default_state: muic-int-default-state { pins = "gpio67"; function = "gpio";
Uses ti,lp8556 backlight with clk-pwm. Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> --- .../dts/qcom-apq8026-samsung-matisse-wifi.dts | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+)