[v3] bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem

Commit Message

Duke Xin(辛安文) Jan. 28, 2023, 2:47 a.m. UTC

The project is based on Qualcomm's sdx6x chips for laptop,so the mhi interface definition and
enumeration align with previous Quectel sdx24 configuration

Signed-off-by: Duke Xin(辛安文) <[e-mail]>
---
 drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Greg Kroah-Hartman Jan. 31, 2023, 9:11 a.m. UTC | #1

On Fri, Jan 27, 2023 at 06:47:54PM -0800, Duke Xin(辛安文) wrote:
> The project is based on Qualcomm's sdx6x chips for laptop,so the mhi interface definition and
> enumeration align with previous Quectel sdx24 configuration
> 
> Signed-off-by: Duke Xin(辛安文) <[e-mail]>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Duke Xin(辛安文) April 3, 2023, 1:21 a.m. UTC | #2

Hi Mani

I'm sorry. I might bother you. 

I want to know the review progress of [PATCH v3], it seems that you have forgotten my [PATCH v3]. You gave some modification suggestions in [PATCH v2], I revised them and submitted them to [PATCH v3].


辛安文Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd. 
            
Mobile: [phone] | Email : [e-mail]  | Tel: [phone]-8632
Website: www.quectel.com  | QQ: 602659072 | Wechat: 15375456183

Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China    
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼  200233

-----邮件原件-----
发件人: Greg KH <[e-mail]> 
发送时间: 2023年1月31日 17:12
收件人: Duke Xin(辛安文) <[e-mail]>
抄送: [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; Jerry Meng(蒙杰) <[e-mail]>; Duke Xin(辛安文) <[e-mail]>
主题: Re: [PATCH v3] bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem

On Fri, Jan 27, 2023 at 06:47:54PM -0800, Duke Xin(辛安文) wrote:
> The project is based on Qualcomm's sdx6x chips for laptop,so the mhi 
> interface definition and enumeration align with previous Quectel sdx24 
> configuration
> 
> Signed-off-by: Duke Xin(辛安文) <[e-mail]>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him a patch that has triggered this response.  He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created.  Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

Manivannan Sadhasivam April 3, 2023, 5:29 a.m. UTC | #3

On Fri, Jan 27, 2023 at 06:47:54PM -0800, Duke Xin(辛安文) wrote:
> The project is based on Qualcomm's sdx6x chips for laptop,so the mhi interface definition and
> enumeration align with previous Quectel sdx24 configuration
> 

The term "project" doesn't make sense here. It should be a "product", right?

Also, the length of the commit message should not exceed 75 characters as per
kernel coding style. Please run checkpatch script on the commit as below before
sending:

scripts/checkpatch.pl --git HEAD

> Signed-off-by: Duke Xin(辛安文) <[e-mail]>
> ---

This patch is of version 3 but you don't include any changelog here to let us
know what has changed since v1.

>  drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index f39657f71483..416dabe2c282 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -335,6 +335,16 @@ static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = {
>  	.sideband_wake = true,
>  };
>  
> +static const struct mhi_pci_dev_info mhi_quectel_rm5xx_info = {
> +	.name = "quectel-rm5xx",
> +	.edl = "qcom/prog_firehose_sdx6x.elf",
> +	.config = &modem_quectel_em1xx_config,
> +	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> +	.dma_data_width = 32,
> +	.mru_default = 32768,
> +	.sideband_wake = true,
> +};
> +
>  static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
>  	MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
>  	MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
> @@ -569,6 +579,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	/* RM520N-GL (sdx6x), eSIM Project */
> +	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004),

During previous version, I asked you to sort this entry as per the ascending
order of PCI IDs i.e., before 0x2001 but you still have it here :/

- Mani

> +		.driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.25.1
>

Manivannan Sadhasivam April 3, 2023, 5:30 a.m. UTC | #4

On Mon, Apr 03, 2023 at 01:21:29AM +0000, Duke Xin(辛安文) wrote:
> Hi Mani
> 
> I'm sorry. I might bother you. 
> 
> I want to know the review progress of [PATCH v3], it seems that you have forgotten my [PATCH v3]. You gave some modification suggestions in [PATCH v2], I revised them and submitted them to [PATCH v3].
> 

Still the patch has some concerns, so I shared some comments. Please fix them
before sending v4.

- Mani

> 
> 辛安文Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd. 
>             
> Mobile: [phone] | Email : [e-mail]  | Tel: [phone]-8632
> Website: www.quectel.com  | QQ: 602659072 | Wechat: 15375456183
> 
> Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China    
> 安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
> HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
> 总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼  200233
> 
> -----邮件原件-----
> 发件人: Greg KH <[e-mail]> 
> 发送时间: 2023年1月31日 17:12
> 收件人: Duke Xin(辛安文) <[e-mail]>
> 抄送: [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; Jerry Meng(蒙杰) <[e-mail]>; Duke Xin(辛安文) <[e-mail]>
> 主题: Re: [PATCH v3] bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem
> 
> On Fri, Jan 27, 2023 at 06:47:54PM -0800, Duke Xin(辛安文) wrote:
> > The project is based on Qualcomm's sdx6x chips for laptop,so the mhi 
> > interface definition and enumeration align with previous Quectel sdx24 
> > configuration
> > 
> > Signed-off-by: Duke Xin(辛安文) <[e-mail]>
> > ---
> >  drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> 
> Hi,
> 
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him a patch that has triggered this response.  He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created.  Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
> 
> You are receiving this message because of the following common error(s) as indicated below:
> 
> - This looks like a new version of a previously submitted patch, but you
>   did not list below the --- line any changes from the previous version.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/process/submitting-patches.rst for what
>   needs to be done here to properly describe this.
> 
> If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
> 
> thanks,
> 
> greg k-h's patch email bot

Patch

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index f39657f71483..416dabe2c282 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -335,6 +335,16 @@  static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = {
 	.sideband_wake = true,
 };
 
+static const struct mhi_pci_dev_info mhi_quectel_rm5xx_info = {
+	.name = "quectel-rm5xx",
+	.edl = "qcom/prog_firehose_sdx6x.elf",
+	.config = &modem_quectel_em1xx_config,
+	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
+	.dma_data_width = 32,
+	.mru_default = 32768,
+	.sideband_wake = true,
+};
+
 static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
 	MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
 	MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
@@ -569,6 +579,9 @@  static const struct pci_device_id mhi_pci_id_table[] = {
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
 	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
 		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+	/* RM520N-GL (sdx6x), eSIM Project */
+	{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004),
+		.driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
 	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },