| Message ID | 20230201154321.276419-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd06d923304355762d426b030a30d99fdf765b84 |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings | expand |
On 1.02.2023 16:43, Krzysztof Kozlowski wrote: > SM8350 pin controller does not have "normal" pin function, so use > "gpio". > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Makes one wonder if it was ever tested, as this would have probably failed when setting pinctrl settings.. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index ece1a7cb8b3b..8b7cc45b0919 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state { > lt9611_state: lt9611-state { > rst-pins { > pins = "gpio48"; > - function = "normal"; > + function = "gpio"; > > output-high; > input-disable;
On 01/02/2023 16:47, Konrad Dybcio wrote: > > > On 1.02.2023 16:43, Krzysztof Kozlowski wrote: >> SM8350 pin controller does not have "normal" pin function, so use >> "gpio". >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > Makes one wonder if it was ever tested, as this would have probably > failed when setting pinctrl settings.. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge") Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts index ece1a7cb8b3b..8b7cc45b0919 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state { lt9611_state: lt9611-state { rst-pins { pins = "gpio48"; - function = "normal"; + function = "gpio"; output-high; input-disable;
SM8350 pin controller does not have "normal" pin function, so use "gpio". Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)