| Message ID | 20230203182132.1307834-11-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dpu: wide planes support | expand |
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: > Set SSPP_SRCn_ADDR registers to 0 while setting up solid fill, as we can > not be sure that the previous address is still valid. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I am yet to confirm with HW team if programming 0 stride and 0 address is absolutely needed for solid fill or not. Ideally, in solid fill mode these should just be ignored by the HW. But this change and the next wont break anything. Should just be a no-op for HW. Hence, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > index abf499275242..4c05f4b5e050 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c > @@ -563,11 +563,16 @@ static void dpu_hw_sspp_setup_csc(struct dpu_hw_sspp *ctx, > static void dpu_hw_sspp_setup_solidfill(struct dpu_sw_pipe *pipe, u32 color) > { > struct dpu_hw_sspp *ctx = pipe->sspp; > + struct dpu_hw_sspp_cfg cfg; > u32 idx; > > if (_sspp_subblk_offset(ctx, DPU_SSPP_SRC, &idx)) > return; > > + /* cleanup source addresses */ > + memset(&cfg, 0, sizeof(cfg)); > + ctx->ops.setup_sourceaddress(pipe, &cfg); > + > if (pipe->multirect_index == DPU_SSPP_RECT_SOLO || > pipe->multirect_index == DPU_SSPP_RECT_0) > DPU_REG_WRITE(&ctx->hw, SSPP_SRC_CONSTANT_COLOR + idx, color);
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c index abf499275242..4c05f4b5e050 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -563,11 +563,16 @@ static void dpu_hw_sspp_setup_csc(struct dpu_hw_sspp *ctx, static void dpu_hw_sspp_setup_solidfill(struct dpu_sw_pipe *pipe, u32 color) { struct dpu_hw_sspp *ctx = pipe->sspp; + struct dpu_hw_sspp_cfg cfg; u32 idx; if (_sspp_subblk_offset(ctx, DPU_SSPP_SRC, &idx)) return; + /* cleanup source addresses */ + memset(&cfg, 0, sizeof(cfg)); + ctx->ops.setup_sourceaddress(pipe, &cfg); + if (pipe->multirect_index == DPU_SSPP_RECT_SOLO || pipe->multirect_index == DPU_SSPP_RECT_0) DPU_REG_WRITE(&ctx->hw, SSPP_SRC_CONSTANT_COLOR + idx, color);
Set SSPP_SRCn_ADDR registers to 0 while setting up solid fill, as we can not be sure that the previous address is still valid. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 5 +++++ 1 file changed, 5 insertions(+)