| Message ID | 20230209232539.91500-1-soyer@irl.hu (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add tri-state-key for oneplus6 | expand |
Hi! > ABS_SND_PROFILE used to describe the state of a multi-value sound profile > switch. This will be used for the tri-state key on OnePlus phones or other > phones. Looks like ABS_PROFILE would be fine to use there, no need to create new one, no? Best regards, Pavel > Signed-off-by: Gergo Koteles <soyer@irl.hu> > --- > Documentation/input/event-codes.rst | 6 ++++++ > drivers/hid/hid-debug.c | 1 + > include/uapi/linux/input-event-codes.h | 1 + > 3 files changed, 8 insertions(+) > > diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst > index b4557462edd7..d43336e64d6a 100644 > --- a/Documentation/input/event-codes.rst > +++ b/Documentation/input/event-codes.rst > @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings: > emitted only when the selected profile changes, indicating the newly > selected profile value. > > +* ABS_SND_PROFILE: > + > + - Used to describe the state of a multi-value sound profile switch. > + An event is emitted only when the selected profile changes, > + indicating the newly selected profile value. > + > * ABS_MT_<name>: > > - Used to describe multitouch input events. Please see > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
Hi Pavel, > Hi! > >> ABS_SND_PROFILE used to describe the state of a multi-value sound profile >> switch. This will be used for the tri-state key on OnePlus phones or other >> phones. > > Looks like ABS_PROFILE would be fine to use there, no need to create > new one, no? > ABS_PROFILE used by some Xbox game controllers to switch controller profiles. In the future, it's imaginable to play games in a linux mobile with the controllers. If we don't want to know in userspace where the event comes from, I think ABS_SND_PROFILE would be better. Thanks, Gergo > Best regards, > Pavel > >> Signed-off-by: Gergo Koteles <soyer@irl.hu> >> --- >> Documentation/input/event-codes.rst | 6 ++++++ >> drivers/hid/hid-debug.c | 1 + >> include/uapi/linux/input-event-codes.h | 1 + >> 3 files changed, 8 insertions(+) >> >> diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst >> index b4557462edd7..d43336e64d6a 100644 >> --- a/Documentation/input/event-codes.rst >> +++ b/Documentation/input/event-codes.rst >> @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings: >> emitted only when the selected profile changes, indicating the newly >> selected profile value. >> >> +* ABS_SND_PROFILE: >> + >> + - Used to describe the state of a multi-value sound profile switch. >> + An event is emitted only when the selected profile changes, >> + indicating the newly selected profile value. >> + >> * ABS_MT_<name>: >> >> - Used to describe multitouch input events. Please see >> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c >
diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst index b4557462edd7..d43336e64d6a 100644 --- a/Documentation/input/event-codes.rst +++ b/Documentation/input/event-codes.rst @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings: emitted only when the selected profile changes, indicating the newly selected profile value. +* ABS_SND_PROFILE: + + - Used to describe the state of a multi-value sound profile switch. + An event is emitted only when the selected profile changes, + indicating the newly selected profile value. + * ABS_MT_<name>: - Used to describe multitouch input events. Please see diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index e213bdde543a..76fb2ecbbc51 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c @@ -1018,6 +1018,7 @@ static const char *absolutes[ABS_CNT] = { [ABS_DISTANCE] = "Distance", [ABS_TILT_X] = "XTilt", [ABS_TILT_Y] = "YTilt", [ABS_TOOL_WIDTH] = "ToolWidth", [ABS_VOLUME] = "Volume", [ABS_PROFILE] = "Profile", + [ABS_SND_PROFILE] = "SoundProfile", [ABS_MISC] = "Misc", [ABS_MT_TOUCH_MAJOR] = "MTMajor", [ABS_MT_TOUCH_MINOR] = "MTMinor", diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h index 022a520e31fc..e765a8f9a3ae 100644 --- a/include/uapi/linux/input-event-codes.h +++ b/include/uapi/linux/input-event-codes.h @@ -866,6 +866,7 @@ #define ABS_VOLUME 0x20 #define ABS_PROFILE 0x21 +#define ABS_SND_PROFILE 0x22 #define ABS_MISC 0x28
ABS_SND_PROFILE used to describe the state of a multi-value sound profile switch. This will be used for the tri-state key on OnePlus phones or other phones. Signed-off-by: Gergo Koteles <soyer@irl.hu> --- Documentation/input/event-codes.rst | 6 ++++++ drivers/hid/hid-debug.c | 1 + include/uapi/linux/input-event-codes.h | 1 + 3 files changed, 8 insertions(+)