| Message ID | 20230213185218.166520-4-quic_molvera@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: qcom_q6v5_pas: Add support for QDU1000/QRU1000 mpss | expand |
On 13/02/2023 19:52, Melody Olvera wrote: > Document "#-power-domain-cells" field for aoss devices as required > by power-controller bindings. The power domain cells are for power domain providers. The reason to add them is because it is a power domain provider. Power-controller bindings do not require drivers which are not power controllers to become such... and this driver is not power domain provider / power controller, is it? > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++ > 1 file changed, 4 insertions(+) Best regards, Krzysztof
On Mon, Feb 13, 2023 at 10:52:12AM -0800, Melody Olvera wrote: > Document "#-power-domain-cells" field for aoss devices as required > by power-controller bindings. > 99512191f4f1 ("soc: qcom: aoss: Drop power domain support") was merged in v5.16, so I don't think this is correct. Please let me know if I'm misunderstood your intent. Thanks, Bjorn > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > index ab607efbb64c..bcfa8e2e6a04 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > @@ -60,6 +60,9 @@ properties: > description: > The single clock represents the QDSS clock. > > + "#power-domain-cells": > + const: 1 > + > required: > - compatible > - reg > @@ -97,6 +100,7 @@ examples: > mboxes = <&apss_shared 0>; > > #clock-cells = <0>; > + #power-domain-cells = <1>; > > cx_cdev: cx { > #cooling-cells = <2>; > -- > 2.25.1 >
On 2/14/2023 9:52 AM, Bjorn Andersson wrote: > On Mon, Feb 13, 2023 at 10:52:12AM -0800, Melody Olvera wrote: >> Document "#-power-domain-cells" field for aoss devices as required >> by power-controller bindings. >> > 99512191f4f1 ("soc: qcom: aoss: Drop power domain support") was merged > in v5.16, so I don't think this is correct. Please let me know if I'm > misunderstood your intent. No, you're correct. Upon reviewing the that commit, this change is wrong and should be dropped. I need to update the device tree accordingly. Thanks for catching that. Thanks, Melody > > Thanks, > Bjorn > >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml >> index ab607efbb64c..bcfa8e2e6a04 100644 >> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml >> @@ -60,6 +60,9 @@ properties: >> description: >> The single clock represents the QDSS clock. >> >> + "#power-domain-cells": >> + const: 1 >> + >> required: >> - compatible >> - reg >> @@ -97,6 +100,7 @@ examples: >> mboxes = <&apss_shared 0>; >> >> #clock-cells = <0>; >> + #power-domain-cells = <1>; >> >> cx_cdev: cx { >> #cooling-cells = <2>; >> -- >> 2.25.1 >>
On 2/14/2023 12:25 AM, Krzysztof Kozlowski wrote: > On 13/02/2023 19:52, Melody Olvera wrote: >> Document "#-power-domain-cells" field for aoss devices as required >> by power-controller bindings. > The power domain cells are for power domain providers. The reason to add > them is because it is a power domain provider. Power-controller bindings > do not require drivers which are not power controllers to become such... > and this driver is not power domain provider / power controller, is it? You're correct; I didn't realize. I'll drop this patch. Thanks, Melody > >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml index ab607efbb64c..bcfa8e2e6a04 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml @@ -60,6 +60,9 @@ properties: description: The single clock represents the QDSS clock. + "#power-domain-cells": + const: 1 + required: - compatible - reg @@ -97,6 +100,7 @@ examples: mboxes = <&apss_shared 0>; #clock-cells = <0>; + #power-domain-cells = <1>; cx_cdev: cx { #cooling-cells = <2>;
Document "#-power-domain-cells" field for aoss devices as required by power-controller bindings. Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> --- Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++ 1 file changed, 4 insertions(+)