diff mbox series

[2/4] ARM: dts: qcom: ipq4018-ap120c-ac: align GPIO hog with DT schema

Message ID 20230214161211.306462-2-robert.marko@sartura.hr (mailing list archive)
State Accepted
Commit a7d2715df2845560302aea9d9922b4bfdf4fe09a
Headers show
Series [1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console | expand

Commit Message

Robert Marko Feb. 14, 2023, 4:12 p.m. UTC
Align USB power GPIO hog node to DT schema.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio Feb. 16, 2023, 10:48 a.m. UTC | #1
On 14.02.2023 17:12, Robert Marko wrote:
> Align USB power GPIO hog node to DT schema.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
Unless you submitted a separate patch for this, I only see
hog being allowed in 845 TLMM.

Konrad
>  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> index 38efd45433da5..cd2a32d0d5548 100644
> --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> @@ -76,7 +76,7 @@ mux_cs {
>  		};
>  	};
>  
> -	usb-power {
> +	usb-power-hog {
>  		line-name = "USB-power";
>  		gpios = <1 GPIO_ACTIVE_HIGH>;
>  		gpio-hog;
Robert Marko Feb. 16, 2023, 10:59 a.m. UTC | #2
On Thu, Feb 16, 2023 at 11:48 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 14.02.2023 17:12, Robert Marko wrote:
> > Align USB power GPIO hog node to DT schema.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> Unless you submitted a separate patch for this, I only see
> hog being allowed in 845 TLMM.

No, cause there is a gpio-hog schema in dtschema and I did not
even look into the pinctrl bindings and dtbs_check is not throwing
a warning.

I dont really see a point further allowing it in pinctrl bindings.

Regards,
Robert
>
> Konrad
> >  arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > index 38efd45433da5..cd2a32d0d5548 100644
> > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
> > @@ -76,7 +76,7 @@ mux_cs {
> >               };
> >       };
> >
> > -     usb-power {
> > +     usb-power-hog {
> >               line-name = "USB-power";
> >               gpios = <1 GPIO_ACTIVE_HIGH>;
> >               gpio-hog;
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
index 38efd45433da5..cd2a32d0d5548 100644
--- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi
@@ -76,7 +76,7 @@  mux_cs {
 		};
 	};
 
-	usb-power {
+	usb-power-hog {
 		line-name = "USB-power";
 		gpios = <1 GPIO_ACTIVE_HIGH>;
 		gpio-hog;