| Message ID | 20230220095401.64196-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 16bd455d0897d1b8b7a9aee2ed51d75b14a34563 |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: sc7280-idp: drop incorrect dai-cells from WCD938x SDW | expand |
On 20.02.2023 10:54, Krzysztof Kozlowski wrote: > The WCD938x audio codec Soundwire interface part is not a DAI and does > not allow sound-dai-cells: > > sc7280-herobrine-crd.dtb: codec@0,4: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi > index cb0cc2ba2fa3..95d9e4a19d76 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi > @@ -419,7 +419,6 @@ &swr0 { > wcd_rx: codec@0,4 { > compatible = "sdw20217010d00"; > reg = <0 4>; > - #sound-dai-cells = <1>; > qcom,rx-port-mapping = <1 2 3 4 5>; > }; > }; > @@ -428,7 +427,6 @@ &swr1 { > wcd_tx: codec@0,3 { > compatible = "sdw20217010d00"; > reg = <0 3>; > - #sound-dai-cells = <1>; > qcom,tx-port-mapping = <1 2 3 4>; > }; > };
Hi, On Mon, Feb 20, 2023 at 1:54 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > The WCD938x audio codec Soundwire interface part is not a DAI and does > not allow sound-dai-cells: > > sc7280-herobrine-crd.dtb: codec@0,4: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 -- > 1 file changed, 2 deletions(-) Like with patch #1, I'm pretty soundwire ignorant but this looks right to me. Reviewed-by: Douglas Anderson <dianders@chromium.org> Seems like folks who were involved in landing the patch that originally added those properties should be CCed on this, though. Adding them. -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index cb0cc2ba2fa3..95d9e4a19d76 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -419,7 +419,6 @@ &swr0 { wcd_rx: codec@0,4 { compatible = "sdw20217010d00"; reg = <0 4>; - #sound-dai-cells = <1>; qcom,rx-port-mapping = <1 2 3 4 5>; }; }; @@ -428,7 +427,6 @@ &swr1 { wcd_tx: codec@0,3 { compatible = "sdw20217010d00"; reg = <0 3>; - #sound-dai-cells = <1>; qcom,tx-port-mapping = <1 2 3 4>; }; };
The WCD938x audio codec Soundwire interface part is not a DAI and does not allow sound-dai-cells: sc7280-herobrine-crd.dtb: codec@0,4: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 2 -- 1 file changed, 2 deletions(-)