| Message ID | 20230310163420.7582-2-quic_kriskura@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add multiport support for DWC3 controllers | expand |
On 10/03/2023 17:34, Krishna Kurapati wrote: > Add bindings to indicate properties required to support multiport > on Snps Dwc3 controller. > > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> What happened with entire previous changelog? This is not v1 but v5 or more? At least v4 was here: https://lore.kernel.org/all/20230115114146.12628-2-quic_kriskura@quicinc.com/ Best regards, Krzysztof
On 3/10/2023 10:11 PM, Krzysztof Kozlowski wrote: > On 10/03/2023 17:34, Krishna Kurapati wrote: >> Add bindings to indicate properties required to support multiport >> on Snps Dwc3 controller. >> >> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > What happened with entire previous changelog? This is not v1 but v5 or > more? At least v4 was here: > > https://lore.kernel.org/all/20230115114146.12628-2-quic_kriskura@quicinc.com/ > > Best regards, > Krzysztof > Hi Krzysztof, Since I pushed a formal patch series, I mentioned PATCH in header instead of "Patch v5". If the RFC v4 is to be followed by Patch-v5, I can re-push the changes again with a proper header and fix my mistake. The previous change log is mentioned in cover letter. https://lore.kernel.org/all/20230310163420.7582-1-quic_kriskura@quicinc.com/ Regards, Krishna,
On 10/03/2023 17:54, Krishna Kurapati PSSNV wrote: > > > On 3/10/2023 10:11 PM, Krzysztof Kozlowski wrote: >> On 10/03/2023 17:34, Krishna Kurapati wrote: >>> Add bindings to indicate properties required to support multiport >>> on Snps Dwc3 controller. >>> >>> Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> >>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> >> What happened with entire previous changelog? This is not v1 but v5 or >> more? At least v4 was here: >> >> https://lore.kernel.org/all/20230115114146.12628-2-quic_kriskura@quicinc.com/ >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > Since I pushed a formal patch series, I mentioned PATCH in header > instead of "Patch v5". If the RFC v4 is to be followed by Patch-v5, I > can re-push the changes again with a proper header and fix my mistake. > > The previous change log is mentioned in cover letter. > OK, for the future, first submission is the v1. This is fifth submission. Best regards, Krzysztof
On Fri, 10 Mar 2023 22:04:13 +0530, Krishna Kurapati wrote: > Add bindings to indicate properties required to support multiport > on Snps Dwc3 controller. > > Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > .../devicetree/bindings/usb/snps,dwc3.yaml | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:90:5: [warning] wrong indentation: expected 6 but found 4 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230310163420.7582-2-quic_kriskura@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index be36956af53b..96701eb5a17c 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -81,15 +81,16 @@ properties: phys: minItems: 1 - maxItems: 2 + maxItems: 8 phy-names: minItems: 1 - maxItems: 2 - items: - enum: - - usb2-phy - - usb3-phy + maxItems: 8 + oneOf: + - items: + enum: [ usb2-phy, usb3-phy ] + - items: + pattern: "^usb[23]-port[0-3]$" power-domains: description:
Add bindings to indicate properties required to support multiport on Snps Dwc3 controller. Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- .../devicetree/bindings/usb/snps,dwc3.yaml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)