| Message ID | 20230317141622.1926573-4-quic_mohs@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add resets for ADSP based audio clock controller driver | expand |
Just remove strcuture from the subject. Quoting Mohammad Rafi Shaik (2023-03-17 07:16:21) > Add the gdsc's in lpass_cc_sc7280_desc strcuture, s/strcuture/struct/ > When qcom,adsp-pil-mode is enabled, gdsc's required to solve Just 'GDSCs', because gdsc isn't owning anything. > dependencies in lpass_audiocc probe. I think you're saying that we need to register the GDSCs when qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node. Otherwise, we don't get any GDSCs provided by that node when we should always be providing them. > > Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280") If the above is right, then this fixes tag is wrong. It should really be Fixes: 0cbcfbe50cbf ("clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon") right?
On 3/18/2023 12:13 AM, Stephen Boyd wrote: > Just remove strcuture from the subject. > > Quoting Mohammad Rafi Shaik (2023-03-17 07:16:21) >> Add the gdsc's in lpass_cc_sc7280_desc strcuture, > s/strcuture/struct/ > >> When qcom,adsp-pil-mode is enabled, gdsc's required to solve > Just 'GDSCs', because gdsc isn't owning anything. > >> dependencies in lpass_audiocc probe. > I think you're saying that we need to register the GDSCs when > qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node. Otherwise, > we don't get any GDSCs provided by that node when we should always be > providing them. Yes, need to register GDSCs when qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node. The lpass_audiocc requires GDSCs to probe become success. >> Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280") > If the above is right, then this fixes tag is wrong. It should really be > > Fixes: 0cbcfbe50cbf ("clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon") > > right? Okay, will change fixes tag.
diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c index 1339f9211a14..134eb1529ede 100644 --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c @@ -696,6 +696,8 @@ static const struct qcom_cc_desc lpass_cc_sc7280_desc = { .config = &lpass_audio_cc_sc7280_regmap_config, .clks = lpass_cc_sc7280_clocks, .num_clks = ARRAY_SIZE(lpass_cc_sc7280_clocks), + .gdscs = lpass_aon_cc_sc7280_gdscs, + .num_gdscs = ARRAY_SIZE(lpass_aon_cc_sc7280_gdscs), }; static const struct qcom_cc_desc lpass_audio_cc_sc7280_desc = {
Add the gdsc's in lpass_cc_sc7280_desc strcuture, When qcom,adsp-pil-mode is enabled, gdsc's required to solve dependencies in lpass_audiocc probe. Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280") Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> --- drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 ++ 1 file changed, 2 insertions(+)