| Message ID | 20230320071211.3005769-2-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] dt-bindings: dma: Add support for SM6115 and QCS2290 SoCs | expand |
On 20.03.2023 08:12, Bhupesh Sharma wrote: > Qualcomm SoCs SM6115 and QRB2290 support BAM engine version > v1.7.4. > > Add the support for the same in driver. Since the reg info of > this version is similar to version v1.7.0, so reuse the same. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > drivers/dma/qcom/bam_dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c > index 1e47d27e1f81..153d189de7d2 100644 > --- a/drivers/dma/qcom/bam_dma.c > +++ b/drivers/dma/qcom/bam_dma.c > @@ -1228,6 +1228,7 @@ static const struct of_device_id bam_of_match[] = { > { .compatible = "qcom,bam-v1.3.0", .data = &bam_v1_3_reg_info }, > { .compatible = "qcom,bam-v1.4.0", .data = &bam_v1_4_reg_info }, > { .compatible = "qcom,bam-v1.7.0", .data = &bam_v1_7_reg_info }, > + { .compatible = "qcom,bam-v1.7.4", .data = &bam_v1_7_reg_info }, The compatible is meaningless as of today (it uses the exact same driver data as v1.7.0), so I'd say going with: compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; is what we want. Konrad > {} > }; >
On Mon, 20 Mar 2023 at 16:12, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 20.03.2023 08:12, Bhupesh Sharma wrote: > > Qualcomm SoCs SM6115 and QRB2290 support BAM engine version > > v1.7.4. > > > > Add the support for the same in driver. Since the reg info of > > this version is similar to version v1.7.0, so reuse the same. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > drivers/dma/qcom/bam_dma.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c > > index 1e47d27e1f81..153d189de7d2 100644 > > --- a/drivers/dma/qcom/bam_dma.c > > +++ b/drivers/dma/qcom/bam_dma.c > > @@ -1228,6 +1228,7 @@ static const struct of_device_id bam_of_match[] = { > > { .compatible = "qcom,bam-v1.3.0", .data = &bam_v1_3_reg_info }, > > { .compatible = "qcom,bam-v1.4.0", .data = &bam_v1_4_reg_info }, > > { .compatible = "qcom,bam-v1.7.0", .data = &bam_v1_7_reg_info }, > > + { .compatible = "qcom,bam-v1.7.4", .data = &bam_v1_7_reg_info }, > The compatible is meaningless as of today (it uses the exact same driver > data as v1.7.0), so I'd say going with: > > compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > > is what we want. Ok, will send a v2. Thanks.
diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index 1e47d27e1f81..153d189de7d2 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -1228,6 +1228,7 @@ static const struct of_device_id bam_of_match[] = { { .compatible = "qcom,bam-v1.3.0", .data = &bam_v1_3_reg_info }, { .compatible = "qcom,bam-v1.4.0", .data = &bam_v1_4_reg_info }, { .compatible = "qcom,bam-v1.7.0", .data = &bam_v1_7_reg_info }, + { .compatible = "qcom,bam-v1.7.4", .data = &bam_v1_7_reg_info }, {} };
Qualcomm SoCs SM6115 and QRB2290 support BAM engine version v1.7.4. Add the support for the same in driver. Since the reg info of this version is similar to version v1.7.0, so reuse the same. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- drivers/dma/qcom/bam_dma.c | 1 + 1 file changed, 1 insertion(+)