| Message ID | 20230322171555.2154-1-lujianhua000@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/4] arm64: dts: qcom: Move elish dts to common dtsi | expand |
On 22/03/2023 18:15, Jianhua Lu wrote: > There are two panel variants of xiaomi-elish, BOE and CSOT panels. > In order to support both panels, so move elish dts to common dtsi. > > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> > --- > Changes in v2: > - Remove sm8250-xiaomi-elish.dtb to avoid build failure. > > arch/arm64/boot/dts/qcom/Makefile | 1 - > ...m8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} | 4 ---- > 2 files changed, 5 deletions(-) > rename arch/arm64/boot/dts/qcom/{sm8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} (99%) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 1a29403400b7..8d2b3c57a4a8 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -183,7 +183,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb > -dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish.dtb This builds, but it is a loss of functionality. Instead the board should be renamed here to one of your final namings, e.g. boe. Best regards, Krzysztof
On Wed, Mar 22, 2023 at 07:08:52PM +0100, Krzysztof Kozlowski wrote: > On 22/03/2023 18:15, Jianhua Lu wrote: > > There are two panel variants of xiaomi-elish, BOE and CSOT panels. > > In order to support both panels, so move elish dts to common dtsi. > > > > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> > > --- > > Changes in v2: > > - Remove sm8250-xiaomi-elish.dtb to avoid build failure. > > > > arch/arm64/boot/dts/qcom/Makefile | 1 - > > ...m8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} | 4 ---- > > 2 files changed, 5 deletions(-) > > rename arch/arm64/boot/dts/qcom/{sm8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} (99%) > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 1a29403400b7..8d2b3c57a4a8 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -183,7 +183,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb > > -dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish.dtb > > This builds, but it is a loss of functionality. Instead the board should > be renamed here to one of your final namings, e.g. boe. Acked > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 1a29403400b7..8d2b3c57a4a8 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -183,7 +183,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb -dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi similarity index 99% rename from arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts rename to arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi index dd79671f5614..a43d4b73ffca 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi @@ -3,8 +3,6 @@ * Copyright (c) 2022, 2023 Jianhua Lu <lujianhua000@gmail.com> */ -/dts-v1/; - #include <dt-bindings/arm/qcom,ids.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sm8250.dtsi" @@ -24,8 +22,6 @@ /delete-node/ &xbl_aop_mem; / { - model = "Xiaomi Mi Pad 5 Pro"; - compatible = "xiaomi,elish", "qcom,sm8250"; classis-type = "tablet"; /* required for bootloader to select correct board */
There are two panel variants of xiaomi-elish, BOE and CSOT panels. In order to support both panels, so move elish dts to common dtsi. Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> --- Changes in v2: - Remove sm8250-xiaomi-elish.dtb to avoid build failure. arch/arm64/boot/dts/qcom/Makefile | 1 - ...m8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} | 4 ---- 2 files changed, 5 deletions(-) rename arch/arm64/boot/dts/qcom/{sm8250-xiaomi-elish.dts => sm8250-xiaomi-elish-common.dtsi} (99%)