| Message ID | 20230323144726.1614344-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] phy: qcom-qmp-combo: fix v3 offsets table | expand |
On 23/03/2023 15:47, Dmitry Baryshkov wrote: > SM8350 and SM8450 use qmp_combo_offsets_v3 table, which doesn't have > PCS_USB offset. Add the usb3_pcs_usb entry to program correct registers > while setting up sm8350 and sm8450 USB+DP combo PHYs. > > Fixes: 05bd18348b88 ("phy: qcom-qmp-combo: Add config for SM6350") > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index c1483e157af4..3b488d12c933 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -1396,6 +1396,7 @@ static const struct qmp_combo_offsets qmp_combo_offsets_v3 = { > .usb3_serdes = 0x1000, > .usb3_pcs_misc = 0x1a00, > .usb3_pcs = 0x1c00, > + .usb3_pcs_usb = 0x1f00, > .dp_serdes = 0x2000, > .dp_txa = 0x2200, > .dp_txb = 0x2600, Thanks for the fix, I totally missed the legacy bindings pcs_usb_offset. Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 23-03-23, 17:47, Dmitry Baryshkov wrote: > SM8350 and SM8450 use qmp_combo_offsets_v3 table, which doesn't have > PCS_USB offset. Add the usb3_pcs_usb entry to program correct registers > while setting up sm8350 and sm8450 USB+DP combo PHYs. Applied, thanks
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index c1483e157af4..3b488d12c933 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -1396,6 +1396,7 @@ static const struct qmp_combo_offsets qmp_combo_offsets_v3 = { .usb3_serdes = 0x1000, .usb3_pcs_misc = 0x1a00, .usb3_pcs = 0x1c00, + .usb3_pcs_usb = 0x1f00, .dp_serdes = 0x2000, .dp_txa = 0x2200, .dp_txb = 0x2600,
SM8350 and SM8450 use qmp_combo_offsets_v3 table, which doesn't have PCS_USB offset. Add the usb3_pcs_usb entry to program correct registers while setting up sm8350 and sm8450 USB+DP combo PHYs. Fixes: 05bd18348b88 ("phy: qcom-qmp-combo: Add config for SM6350") Cc: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 1 + 1 file changed, 1 insertion(+)