| Message ID | 20230325135114.21688-3-me@dylanvanassche.be (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Qualcomm SDM845 SLPI DSP enablement | expand |
Hi Dylan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.3-rc3 next-20230324]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dylan-Van-Assche/dts-arm64-qcom-sdm845-add-SLPI-remoteproc/20230325-215354
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20230325135114.21688-3-me%40dylanvanassche.be
patch subject: [PATCH 2/4] dts: arm64: qcom: sdm845: add SLPI FastRPC support
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20230326/202303260005.DW8hkIxU-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/df03f51210d03566bf0d35a56633d55e3c57b5ad
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dylan-Van-Assche/dts-arm64-qcom-sdm845-add-SLPI-remoteproc/20230325-215354
git checkout df03f51210d03566bf0d35a56633d55e3c57b5ad
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303260005.DW8hkIxU-lkp@intel.com/
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/qcom/sdm845.dtsi:3360.4-5 syntax error
FATAL ERROR: Unable to parse input tree
On 25/03/2023 14:51, Dylan Van Assche wrote: > Qualcomm SDM845 SoC features a SLPI DSP which uses FastRPC through > an allocated memory region to load files from the host filesystem > such as sensor configuration files. > > Add a FastRPC node at /dev/fastrpc-sdsp and a DMA region, similar to > downstream, to allow userspace to communicate with the SLPI via the > FastRPC interface for initializing the sensors on the SLPI. > > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 8dcfe6293762..5a6c7d00719b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -878,6 +878,14 @@ mdata_mem: mpss-metadata { > size = <0 0x4000>; > no-map; > }; > + > + fastrpc_mem: fastrpc { > + compatible = "shared-dma-pool"; > + reusable; > + alloc-ranges = <0 0x00000000 0 0xffffffff>; > + alignment = <0 0x400000>; > + size = <0 0x1000000>; > + }; > }; > > adsp_pas: remoteproc-adsp { > @@ -3344,6 +3352,22 @@ glink-edge { > label = "dsps"; > qcom,remote-pid = <3>; > mboxes = <&apss_shared 24>; > + > + fastrpc { > + compatible = "qcom,fastrpc"; > + qcom,glink-channels = "fastrpcglink-apps-dsp"; > + label = "sdsp"; > + qcom,non-secure-domain; > + qcom,vmids = <0x3 0xF 0x5 0x6>; > + memory-region = <&fastrpc_mem>; > + qcom,assign-all-mem; > + #address-cells = <1>; > + #size-cells = <0>; > + > + compute-cb { Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 8dcfe6293762..5a6c7d00719b 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -878,6 +878,14 @@ mdata_mem: mpss-metadata { size = <0 0x4000>; no-map; }; + + fastrpc_mem: fastrpc { + compatible = "shared-dma-pool"; + reusable; + alloc-ranges = <0 0x00000000 0 0xffffffff>; + alignment = <0 0x400000>; + size = <0 0x1000000>; + }; }; adsp_pas: remoteproc-adsp { @@ -3344,6 +3352,22 @@ glink-edge { label = "dsps"; qcom,remote-pid = <3>; mboxes = <&apss_shared 24>; + + fastrpc { + compatible = "qcom,fastrpc"; + qcom,glink-channels = "fastrpcglink-apps-dsp"; + label = "sdsp"; + qcom,non-secure-domain; + qcom,vmids = <0x3 0xF 0x5 0x6>; + memory-region = <&fastrpc_mem>; + qcom,assign-all-mem; + #address-cells = <1>; + #size-cells = <0>; + + compute-cb { + compatible = "qcom,fastrpc-compute-cb"; + }; + } }; };
Qualcomm SDM845 SoC features a SLPI DSP which uses FastRPC through an allocated memory region to load files from the host filesystem such as sensor configuration files. Add a FastRPC node at /dev/fastrpc-sdsp and a DMA region, similar to downstream, to allow userspace to communicate with the SLPI via the FastRPC interface for initializing the sensors on the SLPI. Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)