| Message ID | 20230329-rfc-msm-dsc-helper-v11-3-30270e1eeac3@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce MSM-specific DSC helpers | expand |
On 2023-05-17 11:51:12, Jessica Zhang wrote: > Add helper to get the integer value of drm_dsc_config.bits_per_pixel > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> Seems fine, but folks might request to make int->integer to make it more clear that it returns the integer part, and/or add the commit body to a documentation comment. Similarly I wonder if we should add a constructor too that can be used in RC table creation and panel drivers. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> - Marijn > --- > include/drm/display/drm_dsc_helper.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/drm/display/drm_dsc_helper.h b/include/drm/display/drm_dsc_helper.h > index ea99b0b90674..b7956830cab9 100644 > --- a/include/drm/display/drm_dsc_helper.h > +++ b/include/drm/display/drm_dsc_helper.h > @@ -9,6 +9,7 @@ > #define DRM_DSC_HELPER_H_ > > #include <drm/display/drm_dsc.h> > +#include <linux/bug.h> > > enum drm_dsc_params_kind { > DRM_DSC_1_2_444, > @@ -26,6 +27,12 @@ void drm_dsc_set_rc_buf_thresh(struct drm_dsc_config *vdsc_cfg); > int drm_dsc_setup_rc_params(struct drm_dsc_config *vdsc_cfg, enum drm_dsc_params_kind kind); > int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg); > > +static inline u32 drm_dsc_get_bpp_int(const struct drm_dsc_config *dsc) > +{ > + WARN_ON_ONCE(dsc->bits_per_pixel & 0xf); > + return dsc->bits_per_pixel >> 4; > +} > + > static inline u8 drm_dsc_initial_scale_value(const struct drm_dsc_config *dsc) > { > return 8 * dsc->rc_model_size / (dsc->rc_model_size - dsc->initial_offset); > > -- > 2.40.1 >
diff --git a/include/drm/display/drm_dsc_helper.h b/include/drm/display/drm_dsc_helper.h index ea99b0b90674..b7956830cab9 100644 --- a/include/drm/display/drm_dsc_helper.h +++ b/include/drm/display/drm_dsc_helper.h @@ -9,6 +9,7 @@ #define DRM_DSC_HELPER_H_ #include <drm/display/drm_dsc.h> +#include <linux/bug.h> enum drm_dsc_params_kind { DRM_DSC_1_2_444, @@ -26,6 +27,12 @@ void drm_dsc_set_rc_buf_thresh(struct drm_dsc_config *vdsc_cfg); int drm_dsc_setup_rc_params(struct drm_dsc_config *vdsc_cfg, enum drm_dsc_params_kind kind); int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg); +static inline u32 drm_dsc_get_bpp_int(const struct drm_dsc_config *dsc) +{ + WARN_ON_ONCE(dsc->bits_per_pixel & 0xf); + return dsc->bits_per_pixel >> 4; +} + static inline u8 drm_dsc_initial_scale_value(const struct drm_dsc_config *dsc) { return 8 * dsc->rc_model_size / (dsc->rc_model_size - dsc->initial_offset);
Add helper to get the integer value of drm_dsc_config.bits_per_pixel Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> --- include/drm/display/drm_dsc_helper.h | 7 +++++++ 1 file changed, 7 insertions(+)