| Message ID | 20230406150633.83351-2-nikita@trvn.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Acer Aspire 1 | expand |
On 6.04.2023 17:06, Nikita Travkin wrote: > lpass clocks are usually blocked from HLOS by the firmware and > instead are managed by the ADSP. Mark them as reserved and explicitly > enable in the CrOS boards that have special, cooperative firmware. > > Signed-off-by: Nikita Travkin <nikita@trvn.ru> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 423630c4d02c..26def6e12723 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -785,6 +785,14 @@ alc5682: codec@1a { > }; > }; > > +&lpasscc { > + status = "okay"; > +}; > + > +&lpass_hm { > + status = "okay"; > +}; > + > &lpass_cpu { > status = "okay"; > _hm should come after _cpu alphabetically w/ that Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 3c799b564b64..6f40301faa1c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 { > power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; > #clock-cells = <1>; > #power-domain-cells = <1>; > + > + status = "reserved"; /* Controlled by ADSP */ > }; > > lpass_cpu: lpass@62d87000 { > @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 { > > #clock-cells = <1>; > #power-domain-cells = <1>; > + > + status = "reserved"; /* Controlled by ADSP */ > }; > }; >
Konrad Dybcio писал(а) 07.04.2023 00:31: > On 6.04.2023 17:06, Nikita Travkin wrote: >> lpass clocks are usually blocked from HLOS by the firmware and >> instead are managed by the ADSP. Mark them as reserved and explicitly >> enable in the CrOS boards that have special, cooperative firmware. >> >> Signed-off-by: Nikita Travkin <nikita@trvn.ru> >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++ >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> index 423630c4d02c..26def6e12723 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> @@ -785,6 +785,14 @@ alc5682: codec@1a { >> }; >> }; >> >> +&lpasscc { >> + status = "okay"; >> +}; >> + >> +&lpass_hm { >> + status = "okay"; >> +}; >> + >> &lpass_cpu { >> status = "okay"; >> > _hm should come after _cpu alphabetically > Oops, will fix, thanks! > w/ that > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index 3c799b564b64..6f40301faa1c 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 { >> power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; >> #clock-cells = <1>; >> #power-domain-cells = <1>; >> + >> + status = "reserved"; /* Controlled by ADSP */ >> }; >> >> lpass_cpu: lpass@62d87000 { >> @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 { >> >> #clock-cells = <1>; >> #power-domain-cells = <1>; >> + >> + status = "reserved"; /* Controlled by ADSP */ >> }; >> }; >>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 423630c4d02c..26def6e12723 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -785,6 +785,14 @@ alc5682: codec@1a { }; }; +&lpasscc { + status = "okay"; +}; + +&lpass_hm { + status = "okay"; +}; + &lpass_cpu { status = "okay"; diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 3c799b564b64..6f40301faa1c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 { power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; #clock-cells = <1>; #power-domain-cells = <1>; + + status = "reserved"; /* Controlled by ADSP */ }; lpass_cpu: lpass@62d87000 { @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 { #clock-cells = <1>; #power-domain-cells = <1>; + + status = "reserved"; /* Controlled by ADSP */ }; };
lpass clocks are usually blocked from HLOS by the firmware and instead are managed by the ADSP. Mark them as reserved and explicitly enable in the CrOS boards that have special, cooperative firmware. Signed-off-by: Nikita Travkin <nikita@trvn.ru> --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++ 2 files changed, 12 insertions(+)