| Message ID | 20230411072840.2751813-4-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: Add Qualcomm RB2 board dts | expand |
On 11.04.2023 09:28, Bhupesh Sharma wrote: > Increase the l22 and l24 load used for uSD and eMMC VMMC. > These need to be increased in order to prevent any voltage drop > issues due to limited current happening during specific operations > (e.g. write). > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- You could have simply squashed this into the patch where you enabled the controllers, so that that commit works reliably for e.g. bisect Konrad > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index c9c6e3787462..dc80f0bca767 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -171,6 +171,8 @@ vreg_l21a_2p704: l21 { > vreg_l22a_2p96: l22 { > regulator-min-microvolt = <2952000>; > regulator-max-microvolt = <3304000>; > + regulator-system-load = <100000>; > + regulator-allow-set-load; > }; > > vreg_l23a_3p3: l23 { > @@ -181,6 +183,8 @@ vreg_l23a_3p3: l23 { > vreg_l24a_2p96: l24 { > regulator-min-microvolt = <2704000>; > regulator-max-microvolt = <3600000>; > + regulator-system-load = <100000>; > + regulator-allow-set-load; > }; > }; > };
On Tue, 11 Apr 2023 at 17:28, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 11.04.2023 09:28, Bhupesh Sharma wrote: > > Increase the l22 and l24 load used for uSD and eMMC VMMC. > > These need to be increased in order to prevent any voltage drop > > issues due to limited current happening during specific operations > > (e.g. write). > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > You could have simply squashed this into the patch where > you enabled the controllers, so that that commit works > reliably for e.g. bisect Yes, but Bjorn asked me to send this separately (via irc). I am fine with squashing this with the previous patch [PATCH 2/3] as well, if Bjorn is OK with it. Thanks, Bhupesh
On Tue, Apr 11, 2023 at 05:43:51PM +0530, Bhupesh Sharma wrote: > On Tue, 11 Apr 2023 at 17:28, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > > > > > On 11.04.2023 09:28, Bhupesh Sharma wrote: > > > Increase the l22 and l24 load used for uSD and eMMC VMMC. > > > These need to be increased in order to prevent any voltage drop > > > issues due to limited current happening during specific operations > > > (e.g. write). > > > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > --- > > You could have simply squashed this into the patch where > > you enabled the controllers, so that that commit works > > reliably for e.g. bisect > > Yes, but Bjorn asked me to send this separately (via irc). > I am fine with squashing this with the previous patch [PATCH 2/3] as > well, if Bjorn is OK with it. > I was trying to say that I was fine with you just fixing the small thing I had asked for and then you could send a separate patch for this when you found the time. I can squash the two while applying, unless anyone else have any concerns with the patches. Regards, Bjorn
On Tue, 11 Apr 2023 at 18:09, Bjorn Andersson <andersson@kernel.org> wrote: > > On Tue, Apr 11, 2023 at 05:43:51PM +0530, Bhupesh Sharma wrote: > > On Tue, 11 Apr 2023 at 17:28, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > > > > > > > > > On 11.04.2023 09:28, Bhupesh Sharma wrote: > > > > Increase the l22 and l24 load used for uSD and eMMC VMMC. > > > > These need to be increased in order to prevent any voltage drop > > > > issues due to limited current happening during specific operations > > > > (e.g. write). > > > > > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > > --- > > > You could have simply squashed this into the patch where > > > you enabled the controllers, so that that commit works > > > reliably for e.g. bisect > > > > Yes, but Bjorn asked me to send this separately (via irc). > > I am fine with squashing this with the previous patch [PATCH 2/3] as > > well, if Bjorn is OK with it. > > > > I was trying to say that I was fine with you just fixing the small thing > I had asked for and then you could send a separate patch for this when > you found the time. > > I can squash the two while applying, unless anyone else have any > concerns with the patches. Sounds good to me. Thanks for your help Bjorn with squashing the patches. Thanks, Bhupesh
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts index c9c6e3787462..dc80f0bca767 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -171,6 +171,8 @@ vreg_l21a_2p704: l21 { vreg_l22a_2p96: l22 { regulator-min-microvolt = <2952000>; regulator-max-microvolt = <3304000>; + regulator-system-load = <100000>; + regulator-allow-set-load; }; vreg_l23a_3p3: l23 { @@ -181,6 +183,8 @@ vreg_l23a_3p3: l23 { vreg_l24a_2p96: l24 { regulator-min-microvolt = <2704000>; regulator-max-microvolt = <3600000>; + regulator-system-load = <100000>; + regulator-allow-set-load; }; }; };
Increase the l22 and l24 load used for uSD and eMMC VMMC. These need to be increased in order to prevent any voltage drop issues due to limited current happening during specific operations (e.g. write). Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 4 ++++ 1 file changed, 4 insertions(+)