| Message ID | 20230411203144.471192-1-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sa8155p-adp: Make compatible the first property | expand |
On 11.04.2023 22:31, Andrew Halaney wrote: > As stated at the below link in another review, compatible is always the > first property. > > Follow suit here to avoid copying incorrectly in the future. > > Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- Thanks for this patch! > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > index 459384ec8f23..8c773b856eb1 100644 > --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > @@ -351,19 +351,18 @@ ðernet { > max-speed = <1000>; > > mdio { > + compatible = "snps,dwmac-mdio"; > #address-cells = <0x1>; > #size-cells = <0x0>; Since you're already touching this file, can you make the -cells values decimal.. > > - compatible = "snps,dwmac-mdio"; > - > /* Micrel KSZ9031RNZ PHY */ > rgmii_phy: phy@7 { > + compatible = "ethernet-phy-ieee802.3-c22"; > reg = <0x7>; > > interrupt-parent = <&tlmm>; ..remove the useless interrupt-parent.. > interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ ...and the similarly not very useful comment here? Konrad > device_type = "ethernet-phy"; > - compatible = "ethernet-phy-ieee802.3-c22"; > }; > }; > };
On Tue, Apr 11, 2023 at 10:44:36PM +0200, Konrad Dybcio wrote: > > > On 11.04.2023 22:31, Andrew Halaney wrote: > > As stated at the below link in another review, compatible is always the > > first property. > > > > Follow suit here to avoid copying incorrectly in the future. > > > > Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > > --- > Thanks for this patch! > > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > > index 459384ec8f23..8c773b856eb1 100644 > > --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > > @@ -351,19 +351,18 @@ ðernet { > > max-speed = <1000>; > > > > mdio { > > + compatible = "snps,dwmac-mdio"; > > #address-cells = <0x1>; > > #size-cells = <0x0>; > Since you're already touching this file, can you make the > -cells values decimal.. > > > > - compatible = "snps,dwmac-mdio"; > > - > > /* Micrel KSZ9031RNZ PHY */ > > rgmii_phy: phy@7 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > reg = <0x7>; > > > > interrupt-parent = <&tlmm>; > ..remove the useless interrupt-parent.. > > > interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ > ...and the similarly not very useful comment here? > > Konrad > Gladly, I'll wait a few days in case someone points something else out before sending a v2 patch series tackling each of those little bits. Thanks, Andrew > > device_type = "ethernet-phy"; > > - compatible = "ethernet-phy-ieee802.3-c22"; > > }; > > }; > > }; >
diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 459384ec8f23..8c773b856eb1 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -351,19 +351,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; };
As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)