| Message ID | 20230413113438.1577658-5-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Qualcomm PMIC TPCM support | expand |
On 2023-04-13 12:34:28, Bryan O'Donoghue wrote: > Add ports as an optional "Add the following ports as optional ...:" > > port@0 to receive an orientation-switch message from the Type-C port or > redriver > > port@1 to subsequently transmit the orientation-switch on once the PHY has > finished doing its orientation turn-around. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml > index d307343388888..9ef69ad12b74a 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml > @@ -65,6 +65,22 @@ properties: > description: Flag the port as possible handler of orientation switching > type: boolean > > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: OF graph bindings that model incoming orientation-switch and > + outgoing orientation-switch messages. An example of an incoming > + orientation-switch message might come form a Type-C connector or a USB Nit: form -> from > + redriver. An example of an output would be a DisplayPort controller. > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Type-C mux orientation-switch input. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: PHY orientation-siwtch output. > + > resets: > items: > - description: reset of phy block. > @@ -279,4 +295,22 @@ examples: > #clock-cells = <1>; > #phy-cells = <0>; > }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + qmpphy_typec_mux_in: endpoint { > + remote-endpoint = <&pmic_typec_mux_out>; > + }; > + }; Nit: space? - Marijn > + port@1 { > + reg = <1>; > + qmpphy_typec_mux_out: endpoint { > + remote-endpoint = <&dp_typec_mux_in>; > + }; > + }; > + }; > }; > -- > 2.39.2 >
On 13/04/2023 13:34, Bryan O'Donoghue wrote: > Add ports as an optional > > port@0 to receive an orientation-switch message from the Type-C port or > redriver > > port@1 to subsequently transmit the orientation-switch on once the PHY has > finished doing its orientation turn-around. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml > index d307343388888..9ef69ad12b74a 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml > @@ -65,6 +65,22 @@ properties: > description: Flag the port as possible handler of orientation switching > type: boolean > > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: OF graph bindings that model incoming orientation-switch and > + outgoing orientation-switch messages. An example of an incoming > + orientation-switch message might come form a Type-C connector or a USB > + redriver. An example of an output would be a DisplayPort controller. > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Type-C mux orientation-switch input. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: PHY orientation-siwtch output. typo: switch I assume both ports are required? Could it work without input or output? Best regards, Krzysztof
On 16/04/2023 18:47, Krzysztof Kozlowski wrote:
> I assume both ports are required? Could it work without input or output?
It can work without an output because we might not have DP switched on
-> bog-standard USB orientation-switching in host-only, device-only or
dual-role modes.
---
bod
On 17/04/2023 02:09, Bryan O'Donoghue wrote: > On 16/04/2023 18:47, Krzysztof Kozlowski wrote: >> I assume both ports are required? Could it work without input or output? > > It can work without an output because we might not have DP switched on > -> bog-standard USB orientation-switching in host-only, device-only or > dual-role modes. > Then I guess: required: - port@0 (or whichever was input) Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml index d307343388888..9ef69ad12b74a 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml @@ -65,6 +65,22 @@ properties: description: Flag the port as possible handler of orientation switching type: boolean + ports: + $ref: /schemas/graph.yaml#/properties/ports + description: OF graph bindings that model incoming orientation-switch and + outgoing orientation-switch messages. An example of an incoming + orientation-switch message might come form a Type-C connector or a USB + redriver. An example of an output would be a DisplayPort controller. + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Type-C mux orientation-switch input. + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: PHY orientation-siwtch output. + resets: items: - description: reset of phy block. @@ -279,4 +295,22 @@ examples: #clock-cells = <1>; #phy-cells = <0>; }; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + qmpphy_typec_mux_in: endpoint { + remote-endpoint = <&pmic_typec_mux_out>; + }; + }; + port@1 { + reg = <1>; + qmpphy_typec_mux_out: endpoint { + remote-endpoint = <&dp_typec_mux_in>; + }; + }; + }; };
Add ports as an optional port@0 to receive an orientation-switch message from the Type-C port or redriver port@1 to subsequently transmit the orientation-switch on once the PHY has finished doing its orientation turn-around. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+)