| Message ID | 20230419211856.79332-7-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [01/18] arm64: dts: qcom: ipq6018: correct qrng unit address | expand |
Il 19/04/23 23:18, Krzysztof Kozlowski ha scritto: > Match unit-address to reg entry to fix dtbs W=1 warnings: > > Warning (simple_bus_reg): /soc@0/mmc@7824000: simple-bus unit address format error, expected "7824900" > Warning (simple_bus_reg): /soc@0/mmc@7864000: simple-bus unit address format error, expected "7864900" > Warning (simple_bus_reg): /soc@0/mmc@7a24000: simple-bus unit address format error, expected "7a24900" > > Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 19.04.2023 23:18, Krzysztof Kozlowski wrote: > Match unit-address to reg entry to fix dtbs W=1 warnings: > > Warning (simple_bus_reg): /soc@0/mmc@7824000: simple-bus unit address format error, expected "7824900" > Warning (simple_bus_reg): /soc@0/mmc@7864000: simple-bus unit address format error, expected "7864900" > Warning (simple_bus_reg): /soc@0/mmc@7a24000: simple-bus unit address format error, expected "7a24900" > > Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/msm8976.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi > index f47fb8ea71e2..753b9a2105ed 100644 > --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi > @@ -822,7 +822,7 @@ spmi_bus: spmi@200f000 { > #interrupt-cells = <4>; > }; > > - sdhc_1: mmc@7824000 { > + sdhc_1: mmc@7824900 { > compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; > reg = <0x07824900 0x500>, <0x07824000 0x800>; > reg-names = "hc", "core"; > @@ -838,7 +838,7 @@ sdhc_1: mmc@7824000 { > status = "disabled"; > }; > > - sdhc_2: mmc@7864000 { > + sdhc_2: mmc@7864900 { > compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; > reg = <0x07864900 0x11c>, <0x07864000 0x800>; > reg-names = "hc", "core"; > @@ -957,7 +957,7 @@ otg: usb@78db000 { > #reset-cells = <1>; > }; > > - sdhc_3: mmc@7a24000 { > + sdhc_3: mmc@7a24900 { > compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; > reg = <0x07a24900 0x11c>, <0x07a24000 0x800>; > reg-names = "hc", "core";
On 2023-04-19 23:18:45, Krzysztof Kozlowski wrote: > Match unit-address to reg entry to fix dtbs W=1 warnings: > > Warning (simple_bus_reg): /soc@0/mmc@7824000: simple-bus unit address format error, expected "7824900" > Warning (simple_bus_reg): /soc@0/mmc@7864000: simple-bus unit address format error, expected "7864900" > Warning (simple_bus_reg): /soc@0/mmc@7a24000: simple-bus unit address format error, expected "7a24900" > > Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Looks like we used/kept the "core" rather than "hc" addresses here when porting from downstream. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > arch/arm64/boot/dts/qcom/msm8976.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi > index f47fb8ea71e2..753b9a2105ed 100644 > --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi > @@ -822,7 +822,7 @@ spmi_bus: spmi@200f000 { > #interrupt-cells = <4>; > }; > > - sdhc_1: mmc@7824000 { > + sdhc_1: mmc@7824900 { > compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; > reg = <0x07824900 0x500>, <0x07824000 0x800>; > reg-names = "hc", "core"; > @@ -838,7 +838,7 @@ sdhc_1: mmc@7824000 { > status = "disabled"; > }; > > - sdhc_2: mmc@7864000 { > + sdhc_2: mmc@7864900 { > compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; > reg = <0x07864900 0x11c>, <0x07864000 0x800>; > reg-names = "hc", "core"; > @@ -957,7 +957,7 @@ otg: usb@78db000 { > #reset-cells = <1>; > }; > > - sdhc_3: mmc@7a24000 { > + sdhc_3: mmc@7a24900 { > compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; > reg = <0x07a24900 0x11c>, <0x07a24000 0x800>; > reg-names = "hc", "core"; > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi index f47fb8ea71e2..753b9a2105ed 100644 --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi @@ -822,7 +822,7 @@ spmi_bus: spmi@200f000 { #interrupt-cells = <4>; }; - sdhc_1: mmc@7824000 { + sdhc_1: mmc@7824900 { compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; reg = <0x07824900 0x500>, <0x07824000 0x800>; reg-names = "hc", "core"; @@ -838,7 +838,7 @@ sdhc_1: mmc@7824000 { status = "disabled"; }; - sdhc_2: mmc@7864000 { + sdhc_2: mmc@7864900 { compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; reg = <0x07864900 0x11c>, <0x07864000 0x800>; reg-names = "hc", "core"; @@ -957,7 +957,7 @@ otg: usb@78db000 { #reset-cells = <1>; }; - sdhc_3: mmc@7a24000 { + sdhc_3: mmc@7a24900 { compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4"; reg = <0x07a24900 0x11c>, <0x07a24000 0x800>; reg-names = "hc", "core";
Match unit-address to reg entry to fix dtbs W=1 warnings: Warning (simple_bus_reg): /soc@0/mmc@7824000: simple-bus unit address format error, expected "7824900" Warning (simple_bus_reg): /soc@0/mmc@7864000: simple-bus unit address format error, expected "7864900" Warning (simple_bus_reg): /soc@0/mmc@7a24000: simple-bus unit address format error, expected "7a24900" Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/msm8976.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)