diff mbox series

arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c

Message ID 20230504160430.4014206-1-dmitry.baryshkov@linaro.org (mailing list archive)
State Accepted
Headers show
Series arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c | expand

Commit Message

Dmitry Baryshkov May 4, 2023, 4:04 p.m. UTC
Now as both lt9611 and drm/msm drivers were updated to handle the 4k
modes over DSI, enable "bonded" DSI mode on DB845c. This way the board
utilizes both DSI links and thus can support 4k on the HDMI output.

Cc: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)

Comments

Konrad Dybcio May 4, 2023, 5:11 p.m. UTC | #1
On 4.05.2023 18:04, Dmitry Baryshkov wrote:
> Now as both lt9611 and drm/msm drivers were updated to handle the 4k
> modes over DSI, enable "bonded" DSI mode on DB845c. This way the board
> utilizes both DSI links and thus can support 4k on the HDMI output.
> 
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index e14fe9bbb386..4dea2c04b22f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -419,6 +419,9 @@ &dsi0 {
>  	status = "okay";
P.S. wanna move status last by chance?

Konrad
>  	vdda-supply = <&vreg_l26a_1p2>;
>  
> +	qcom,dual-dsi-mode;
> +	qcom,master-dsi;
> +
>  	ports {
>  		port@1 {
>  			endpoint {
> @@ -434,6 +437,31 @@ &dsi0_phy {
>  	vdds-supply = <&vreg_l1a_0p875>;
>  };
>  
> +&dsi1 {
> +	vdda-supply = <&vreg_l26a_1p2>;
> +
> +	qcom,dual-dsi-mode;
> +
> +	/* DSI1 is slave, so use DSI0 clocks */
> +	assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
> +
> +	status = "okay";
> +
> +	ports {
> +		port@1 {
> +			endpoint {
> +				remote-endpoint = <&lt9611_b>;
> +				data-lanes = <0 1 2 3>;
> +			};
> +		};
> +	};
> +};
> +
> +&dsi1_phy {
> +	vdds-supply = <&vreg_l1a_0p875>;
> +	status = "okay";
> +};
> +
>  &gcc {
>  	protected-clocks = <GCC_QSPI_CORE_CLK>,
>  			   <GCC_QSPI_CORE_CLK_SRC>,
> @@ -493,6 +521,14 @@ lt9611_a: endpoint {
>  				};
>  			};
>  
> +			port@1 {
> +				reg = <1>;
> +
> +				lt9611_b: endpoint {
> +					remote-endpoint = <&dsi1_out>;
> +				};
> +			};
> +
>  			port@2 {
>  				reg = <2>;
>
Dmitry Baryshkov May 4, 2023, 5:47 p.m. UTC | #2
On Thu, 4 May 2023 at 20:11, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 4.05.2023 18:04, Dmitry Baryshkov wrote:
> > Now as both lt9611 and drm/msm drivers were updated to handle the 4k
> > modes over DSI, enable "bonded" DSI mode on DB845c. This way the board
> > utilizes both DSI links and thus can support 4k on the HDMI output.
> >
> > Cc: Amit Pundir <amit.pundir@linaro.org>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Konrad
> >  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 36 ++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> > index e14fe9bbb386..4dea2c04b22f 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> > @@ -419,6 +419,9 @@ &dsi0 {
> >       status = "okay";
> P.S. wanna move status last by chance?

Not within this patch, it is not relevant to bonded DSI mode.

>
> Konrad
> >       vdda-supply = <&vreg_l26a_1p2>;
> >
> > +     qcom,dual-dsi-mode;
> > +     qcom,master-dsi;
> > +
> >       ports {
> >               port@1 {
> >                       endpoint {
> > @@ -434,6 +437,31 @@ &dsi0_phy {
> >       vdds-supply = <&vreg_l1a_0p875>;
> >  };
> >
> > +&dsi1 {
> > +     vdda-supply = <&vreg_l26a_1p2>;
> > +
> > +     qcom,dual-dsi-mode;
> > +
> > +     /* DSI1 is slave, so use DSI0 clocks */
> > +     assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
> > +
> > +     status = "okay";
> > +
> > +     ports {
> > +             port@1 {
> > +                     endpoint {
> > +                             remote-endpoint = <&lt9611_b>;
> > +                             data-lanes = <0 1 2 3>;
> > +                     };
> > +             };
> > +     };
> > +};
> > +
> > +&dsi1_phy {
> > +     vdds-supply = <&vreg_l1a_0p875>;
> > +     status = "okay";
> > +};
> > +
> >  &gcc {
> >       protected-clocks = <GCC_QSPI_CORE_CLK>,
> >                          <GCC_QSPI_CORE_CLK_SRC>,
> > @@ -493,6 +521,14 @@ lt9611_a: endpoint {
> >                               };
> >                       };
> >
> > +                     port@1 {
> > +                             reg = <1>;
> > +
> > +                             lt9611_b: endpoint {
> > +                                     remote-endpoint = <&dsi1_out>;
> > +                             };
> > +                     };
> > +
> >                       port@2 {
> >                               reg = <2>;
> >
Konrad Dybcio May 4, 2023, 5:53 p.m. UTC | #3
On 4.05.2023 19:47, Dmitry Baryshkov wrote:
> On Thu, 4 May 2023 at 20:11, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 4.05.2023 18:04, Dmitry Baryshkov wrote:
>>> Now as both lt9611 and drm/msm drivers were updated to handle the 4k
>>> modes over DSI, enable "bonded" DSI mode on DB845c. This way the board
>>> utilizes both DSI links and thus can support 4k on the HDMI output.
>>>
>>> Cc: Amit Pundir <amit.pundir@linaro.org>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> Konrad
>>>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 36 ++++++++++++++++++++++
>>>  1 file changed, 36 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>>> index e14fe9bbb386..4dea2c04b22f 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>>> @@ -419,6 +419,9 @@ &dsi0 {
>>>       status = "okay";
>> P.S. wanna move status last by chance?
> 
> Not within this patch, it is not relevant to bonded DSI mode.
Of course.

Konrad
> 
>>
>> Konrad
>>>       vdda-supply = <&vreg_l26a_1p2>;
>>>
>>> +     qcom,dual-dsi-mode;
>>> +     qcom,master-dsi;
>>> +
>>>       ports {
>>>               port@1 {
>>>                       endpoint {
>>> @@ -434,6 +437,31 @@ &dsi0_phy {
>>>       vdds-supply = <&vreg_l1a_0p875>;
>>>  };
>>>
>>> +&dsi1 {
>>> +     vdda-supply = <&vreg_l26a_1p2>;
>>> +
>>> +     qcom,dual-dsi-mode;
>>> +
>>> +     /* DSI1 is slave, so use DSI0 clocks */
>>> +     assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
>>> +
>>> +     status = "okay";
>>> +
>>> +     ports {
>>> +             port@1 {
>>> +                     endpoint {
>>> +                             remote-endpoint = <&lt9611_b>;
>>> +                             data-lanes = <0 1 2 3>;
>>> +                     };
>>> +             };
>>> +     };
>>> +};
>>> +
>>> +&dsi1_phy {
>>> +     vdds-supply = <&vreg_l1a_0p875>;
>>> +     status = "okay";
>>> +};
>>> +
>>>  &gcc {
>>>       protected-clocks = <GCC_QSPI_CORE_CLK>,
>>>                          <GCC_QSPI_CORE_CLK_SRC>,
>>> @@ -493,6 +521,14 @@ lt9611_a: endpoint {
>>>                               };
>>>                       };
>>>
>>> +                     port@1 {
>>> +                             reg = <1>;
>>> +
>>> +                             lt9611_b: endpoint {
>>> +                                     remote-endpoint = <&dsi1_out>;
>>> +                             };
>>> +                     };
>>> +
>>>                       port@2 {
>>>                               reg = <2>;
>>>
> 
> 
>
Bjorn Andersson May 25, 2023, 4:53 a.m. UTC | #4
On Thu, 4 May 2023 19:04:30 +0300, Dmitry Baryshkov wrote:
> Now as both lt9611 and drm/msm drivers were updated to handle the 4k
> modes over DSI, enable "bonded" DSI mode on DB845c. This way the board
> utilizes both DSI links and thus can support 4k on the HDMI output.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c
      commit: 8721e18ca6960f3c5a6a7f58245d9ab084ad09dd

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index e14fe9bbb386..4dea2c04b22f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -419,6 +419,9 @@  &dsi0 {
 	status = "okay";
 	vdda-supply = <&vreg_l26a_1p2>;
 
+	qcom,dual-dsi-mode;
+	qcom,master-dsi;
+
 	ports {
 		port@1 {
 			endpoint {
@@ -434,6 +437,31 @@  &dsi0_phy {
 	vdds-supply = <&vreg_l1a_0p875>;
 };
 
+&dsi1 {
+	vdda-supply = <&vreg_l26a_1p2>;
+
+	qcom,dual-dsi-mode;
+
+	/* DSI1 is slave, so use DSI0 clocks */
+	assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>;
+
+	status = "okay";
+
+	ports {
+		port@1 {
+			endpoint {
+				remote-endpoint = <&lt9611_b>;
+				data-lanes = <0 1 2 3>;
+			};
+		};
+	};
+};
+
+&dsi1_phy {
+	vdds-supply = <&vreg_l1a_0p875>;
+	status = "okay";
+};
+
 &gcc {
 	protected-clocks = <GCC_QSPI_CORE_CLK>,
 			   <GCC_QSPI_CORE_CLK_SRC>,
@@ -493,6 +521,14 @@  lt9611_a: endpoint {
 				};
 			};
 
+			port@1 {
+				reg = <1>;
+
+				lt9611_b: endpoint {
+					remote-endpoint = <&dsi1_out>;
+				};
+			};
+
 			port@2 {
 				reg = <2>;