| Message ID | 20230517182133.72590-2-me@dylanvanassche.be (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: pmi8998: add and enable flash LED | expand |
On 17/05/2023 20:21, Dylan Van Assche wrote: > Qualcomm PMIC PMI8998 has a 3 channel flash LED driver which is used > by many phones for 1 or 2 flash LEDs. Each LED can be used in flash mode > or torch mode. Add the flash LED node to PMI8998 DTS. > > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index ffe587f281d8..89f959353ad5 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -60,6 +60,12 @@ pmi8998_lpg: pwm { > status = "disabled"; > }; > > + pmi8998_flash: led-controller@d300 { > + compatible = "qcom,spmi-flash-led"; This cannot be alone. It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi index ffe587f281d8..89f959353ad5 100644 --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi @@ -60,6 +60,12 @@ pmi8998_lpg: pwm { status = "disabled"; }; + pmi8998_flash: led-controller@d300 { + compatible = "qcom,spmi-flash-led"; + reg = <0xd300>; + status = "disabled"; + }; + pmi8998_wled: leds@d800 { compatible = "qcom,pmi8998-wled"; reg = <0xd800>, <0xd900>;
Qualcomm PMIC PMI8998 has a 3 channel flash LED driver which is used by many phones for 1 or 2 flash LEDs. Each LED can be used in flash mode or torch mode. Add the flash LED node to PMI8998 DTS. Signed-off-by: Dylan Van Assche <me@dylanvanassche.be> --- arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)