| Message ID | 20230523135733.3852-5-quic_kbajaj@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: qdu1000: add SDHCI | expand |
On 23.05.2023 15:57, Komal Bajaj wrote: > Add sdhci node for emmc in qdu1000-idp. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > index 9e9fd4b8023e..6e988e90aa50 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > @@ -448,6 +448,29 @@ > status = "okay"; > }; > > +&sdhc { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc_on_state>; > + pinctrl-1 = <&sdc_off_state>; Please do property-n property-names we've had a little bit of a mess over the years but we're trying to unify that. With that: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > + > + cap-mmc-hw-reset; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > + > + non-removable; > + no-sd; > + no-sdio; > + > + supports-cqe; > + > + vmmc-supply = <&vreg_l10a_2p95>; > + vqmmc-supply = <&vreg_l7a_1p8>; > + > + status = "okay"; > +}; > + > &uart7 { > status = "okay"; > }; > -- > 2.17.1 >
On 5/27/2023 4:52 AM, Konrad Dybcio wrote: > > On 23.05.2023 15:57, Komal Bajaj wrote: >> Add sdhci node for emmc in qdu1000-idp. >> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> index 9e9fd4b8023e..6e988e90aa50 100644 >> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> @@ -448,6 +448,29 @@ >> status = "okay"; >> }; >> >> +&sdhc { >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&sdc_on_state>; >> + pinctrl-1 = <&sdc_off_state>; > Please do > > property-n > property-names > > we've had a little bit of a mess over the years but we're trying > to unify that. Sure, will change in the next patch set. Thanks Komal > > With that: > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad >> + >> + cap-mmc-hw-reset; >> + mmc-ddr-1_8v; >> + mmc-hs200-1_8v; >> + mmc-hs400-1_8v; >> + mmc-hs400-enhanced-strobe; >> + >> + non-removable; >> + no-sd; >> + no-sdio; >> + >> + supports-cqe; >> + >> + vmmc-supply = <&vreg_l10a_2p95>; >> + vqmmc-supply = <&vreg_l7a_1p8>; >> + >> + status = "okay"; >> +}; >> + >> &uart7 { >> status = "okay"; >> }; >> -- >> 2.17.1 >>
diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts index 9e9fd4b8023e..6e988e90aa50 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts @@ -448,6 +448,29 @@ status = "okay"; }; +&sdhc { + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc_on_state>; + pinctrl-1 = <&sdc_off_state>; + + cap-mmc-hw-reset; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; + + non-removable; + no-sd; + no-sdio; + + supports-cqe; + + vmmc-supply = <&vreg_l10a_2p95>; + vqmmc-supply = <&vreg_l7a_1p8>; + + status = "okay"; +}; + &uart7 { status = "okay"; };
Add sdhci node for emmc in qdu1000-idp. Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> --- arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) -- 2.17.1