| Message ID | 20230524230459.120681-1-guptarud@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi | expand |
On Wed, May 24, 2023 at 07:04:54PM -0400, Rudraksha Gupta wrote: Thank you for your patches Rudraksha! Please use: git log --oneline -- arch/arm/boot/dts/qcom-smm8960.dtsi And look at how other patches to this file has prefixed their subject line. Then please follow this in your patches (it differs between patches...). > Allows msm8960 DTS files to reference the sleep_clk node. > Please make the purpose clear in your commit message. Specifically, which part of msm8960 dts needs to reference the sleep clock? Please also include a cover letter (git format-patch --cover-letter) when you send a series of patches. Regards, Bjorn > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index 2a668cd535cc..a4d8dd2d24a6 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -71,7 +71,7 @@ pxo_board: pxo_board { > clock-output-names = "pxo_board"; > }; > > - sleep_clk { > + sleep_clk: sleep_clk { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <32768>; > -- > 2.34.1 >
This patch series adds support for the Samsung Galaxy Express SGH-I437. Currently the following things work on this phone: UART, eMMC, SD Card, and USB. version 2: - Combined patch 1 into patch 4, as the sleep_clk label is specifically needed for the USB node. - Reformatted the commit messages to align with the style used in other commit messages that modify the same files. - Included a cover letter to provide an overview of the patch series. - Slight refactoring of the device tree source (DTS) file. Rudraksha Gupta (4): dt-bindings: arm: qcom: Add Samsung Galaxy Express dt-bindings: Add qcom,usb-hs-phy-msm8960 ARM: dts: qcom: msm8960: Add USB node ARM: dts: qcom: Add Samsung Galaxy Express support .../devicetree/bindings/arm/qcom.yaml | 1 + .../bindings/phy/qcom,usb-hs-phy.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + .../dts/qcom-msm8960-samsung-expressatt.dts | 334 ++++++++++++++++++ arch/arm/boot/dts/qcom-msm8960.dtsi | 35 +- 5 files changed, 371 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
On 28/05/2023 02:10, Rudraksha Gupta wrote: > This patch series adds support for the Samsung Galaxy Express SGH-I437. > Currently the following things work on this phone: UART, eMMC, SD Card, and USB. > > version 2: > - Combined patch 1 into patch 4, as the sleep_clk label is specifically needed for the USB node. > - Reformatted the commit messages to align with the style used in other commit messages that modify the same files. > - Included a cover letter to provide an overview of the patch series. > - Slight refactoring of the device tree source (DTS) file. > Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi index 2a668cd535cc..a4d8dd2d24a6 100644 --- a/arch/arm/boot/dts/qcom-msm8960.dtsi +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi @@ -71,7 +71,7 @@ pxo_board: pxo_board { clock-output-names = "pxo_board"; }; - sleep_clk { + sleep_clk: sleep_clk { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <32768>;
Allows msm8960 DTS files to reference the sleep_clk node. Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> --- arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)