| Message ID | 20230526-topic-smd_icc-v1-1-1bf8e6663c4e@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Restructure RPM SMD ICC | expand |
On 30/05/2023 13:20, Konrad Dybcio wrote: > Add a preprocessor define to indicate the number of RPM contexts/states. > While at it, use tabs instead of spaces for the existing entries. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > include/linux/soc/qcom/smd-rpm.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h > index 2990f425fdef..99499e4b080e 100644 > --- a/include/linux/soc/qcom/smd-rpm.h > +++ b/include/linux/soc/qcom/smd-rpm.h > @@ -4,8 +4,9 @@ > > struct qcom_smd_rpm; > > -#define QCOM_SMD_RPM_ACTIVE_STATE 0 > -#define QCOM_SMD_RPM_SLEEP_STATE 1 > +#define QCOM_SMD_RPM_ACTIVE_STATE 0 > +#define QCOM_SMD_RPM_SLEEP_STATE 1 This is what we usually try to abstain from: ident changes + functional changes. I'd say, leave spaces as is and just add the new entry. > +#define QCOM_SMD_RPM_STATE_NUM 2 > > /* > * Constants used for addressing resources in the RPM. >
On 1.06.2023 11:20, Dmitry Baryshkov wrote: > On 30/05/2023 13:20, Konrad Dybcio wrote: >> Add a preprocessor define to indicate the number of RPM contexts/states. >> While at it, use tabs instead of spaces for the existing entries. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> include/linux/soc/qcom/smd-rpm.h | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h >> index 2990f425fdef..99499e4b080e 100644 >> --- a/include/linux/soc/qcom/smd-rpm.h >> +++ b/include/linux/soc/qcom/smd-rpm.h >> @@ -4,8 +4,9 @@ >> struct qcom_smd_rpm; >> -#define QCOM_SMD_RPM_ACTIVE_STATE 0 >> -#define QCOM_SMD_RPM_SLEEP_STATE 1 >> +#define QCOM_SMD_RPM_ACTIVE_STATE 0 >> +#define QCOM_SMD_RPM_SLEEP_STATE 1 > > This is what we usually try to abstain from: ident changes + functional changes. I'd say, leave spaces as is and just add the new entry. I think I might wanna turn this into an enum.. Also, I'd like to rename it but that's a story for another day, as it'd require even more messy merging.. Konrad > >> +#define QCOM_SMD_RPM_STATE_NUM 2 >> /* >> * Constants used for addressing resources in the RPM. >> >
diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h index 2990f425fdef..99499e4b080e 100644 --- a/include/linux/soc/qcom/smd-rpm.h +++ b/include/linux/soc/qcom/smd-rpm.h @@ -4,8 +4,9 @@ struct qcom_smd_rpm; -#define QCOM_SMD_RPM_ACTIVE_STATE 0 -#define QCOM_SMD_RPM_SLEEP_STATE 1 +#define QCOM_SMD_RPM_ACTIVE_STATE 0 +#define QCOM_SMD_RPM_SLEEP_STATE 1 +#define QCOM_SMD_RPM_STATE_NUM 2 /* * Constants used for addressing resources in the RPM.
Add a preprocessor define to indicate the number of RPM contexts/states. While at it, use tabs instead of spaces for the existing entries. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- include/linux/soc/qcom/smd-rpm.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)