| Message ID | 20230530-msm8939-regulators-v1-3-a3c3ac833567@gerhold.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 209aea1ad505519faf018b596e4fdca0d0569469 |
| Headers | show |
| Series | arm64: dts: qcom: msm8939: Rework regulator constraints | expand |
On 14/06/2023 08:16, Stephan Gerhold wrote: > msm8939-sony-xperia-kanuti-tulip.dts has several regulator voltages > that do not quite seem to match what is used in the vendor kernel. > In particular: > > - l10 is fixed at 2.8V [1, 2] > - l11/l12 are 2.95V max [1] > > [1]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.BR.1.3.3_rb2.14/arch/arm/boot/dts/qcom/msm8939-regulator.dtsi > [2]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.BR.1.3.3_rb2.14/arch/arm/boot/dts/qcom/msm8939-kanuti_tulip.dtsi#L671C1-L673 > > Fixes: f1134f738fad ("arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> I think I probably just copied the Square regulator setup here, so thanks for doing this extra work. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts b/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts index a9df8dab5481..dc5b8cd5b9f4 100644 --- a/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts +++ b/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts @@ -110,20 +110,20 @@ pm8916_l9: l9 { }; pm8916_l10: l10 { - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; }; pm8916_l11: l11 { regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; + regulator-max-microvolt = <2950000>; regulator-system-load = <200000>; regulator-allow-set-load; }; pm8916_l12: l12 { regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; + regulator-max-microvolt = <2950000>; }; pm8916_l13: l13 {
msm8939-sony-xperia-kanuti-tulip.dts has several regulator voltages that do not quite seem to match what is used in the vendor kernel. In particular: - l10 is fixed at 2.8V [1, 2] - l11/l12 are 2.95V max [1] [1]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.BR.1.3.3_rb2.14/arch/arm/boot/dts/qcom/msm8939-regulator.dtsi [2]: https://github.com/sonyxperiadev/kernel/blob/aosp/LA.BR.1.3.3_rb2.14/arch/arm/boot/dts/qcom/msm8939-kanuti_tulip.dtsi#L671C1-L673 Fixes: f1134f738fad ("arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua") Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)