| Message ID | 20230601152026.1182648-6-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/8] pinctrl: qcom: qdf2xxx: drop ACPI_PTR | expand |
On 1.06.2023 17:20, Krzysztof Kozlowski wrote: > Makefile selected Qualcomm pinctrl drivers only for ARCH_QCOM, making > any COMPILE_TEST options inside Kconfig ((ARCH_QCOM || COMPILE_TEST) or > (OF || COMPILE_TEST)) not effective. Always descent to the qcom > subdirectory to fix this. All individual drivers are selected in > Makefile via dedicated CONFIG entries, thus this should not have > functional impact except when compile testing. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Should analogous changes be made for all remaining obj-$(CONFIG_PINCTRL_VENDOR) entries? Konrad > drivers/pinctrl/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index e196c6e324ad..482b391b5deb 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -66,7 +66,7 @@ obj-y += nomadik/ > obj-y += nuvoton/ > obj-y += nxp/ > obj-$(CONFIG_PINCTRL_PXA) += pxa/ > -obj-$(CONFIG_ARCH_QCOM) += qcom/ > +obj-y += qcom/ > obj-$(CONFIG_PINCTRL_RENESAS) += renesas/ > obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/ > obj-$(CONFIG_PINCTRL_SPEAR) += spear/
On 1.06.2023 17:20, Krzysztof Kozlowski wrote: > Makefile selected Qualcomm pinctrl drivers only for ARCH_QCOM, making > any COMPILE_TEST options inside Kconfig ((ARCH_QCOM || COMPILE_TEST) or > (OF || COMPILE_TEST)) not effective. Always descent to the qcom > subdirectory to fix this. All individual drivers are selected in > Makefile via dedicated CONFIG entries, thus this should not have > functional impact except when compile testing. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/pinctrl/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index e196c6e324ad..482b391b5deb 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -66,7 +66,7 @@ obj-y += nomadik/ > obj-y += nuvoton/ > obj-y += nxp/ > obj-$(CONFIG_PINCTRL_PXA) += pxa/ > -obj-$(CONFIG_ARCH_QCOM) += qcom/ > +obj-y += qcom/ > obj-$(CONFIG_PINCTRL_RENESAS) += renesas/ > obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/ > obj-$(CONFIG_PINCTRL_SPEAR) += spear/
On 02/06/2023 11:08, Konrad Dybcio wrote: > > > On 1.06.2023 17:20, Krzysztof Kozlowski wrote: >> Makefile selected Qualcomm pinctrl drivers only for ARCH_QCOM, making >> any COMPILE_TEST options inside Kconfig ((ARCH_QCOM || COMPILE_TEST) or >> (OF || COMPILE_TEST)) not effective. Always descent to the qcom >> subdirectory to fix this. All individual drivers are selected in >> Makefile via dedicated CONFIG entries, thus this should not have >> functional impact except when compile testing. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > Should analogous changes be made for all remaining > obj-$(CONFIG_PINCTRL_VENDOR) entries? Only for ones depending on ARCH_XXX and that requires actual compile testing which might point to missing dependencies etc. Entries depending on selectable PINCTRL_VENDOR are already compile-testable (see Samsung for example). Best regards, Krzysztof
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index e196c6e324ad..482b391b5deb 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -66,7 +66,7 @@ obj-y += nomadik/ obj-y += nuvoton/ obj-y += nxp/ obj-$(CONFIG_PINCTRL_PXA) += pxa/ -obj-$(CONFIG_ARCH_QCOM) += qcom/ +obj-y += qcom/ obj-$(CONFIG_PINCTRL_RENESAS) += renesas/ obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/ obj-$(CONFIG_PINCTRL_SPEAR) += spear/
Makefile selected Qualcomm pinctrl drivers only for ARCH_QCOM, making any COMPILE_TEST options inside Kconfig ((ARCH_QCOM || COMPILE_TEST) or (OF || COMPILE_TEST)) not effective. Always descent to the qcom subdirectory to fix this. All individual drivers are selected in Makefile via dedicated CONFIG entries, thus this should not have functional impact except when compile testing. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/pinctrl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)