| Message ID | 20230604063032.365775-3-guptarud@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Samsung Galaxy Express SGH-I437 Support | expand |
On Sun, 04 Jun 2023 02:30:19 -0400, Rudraksha Gupta wrote: > Adds qcom,usb-hs-phy-msm8960 compatible > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: resets: [[4294967295, 10], [1, 0]] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names:0: 'por' was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names: ['phy', 'por'] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230604063032.365775-3-guptarud@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 04/06/2023 08:30, Rudraksha Gupta wrote: > Adds qcom,usb-hs-phy-msm8960 compatible > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > index aa97478dd016..63b6914993fe 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > @@ -13,7 +13,9 @@ if: > properties: > compatible: > contains: > - const: qcom,usb-hs-phy-apq8064 > + items: > + - const: qcom,usb-hs-phy-apq8064 > + - const: qcom,usb-hs-phy-msm8960 I have no clue what you want to achieve here. You break the bindings. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
On Sun Jun 4, 2023 at 3:23 AM EDT, Rob Herring wrote: > > On Sun, 04 Jun 2023 02:30:19 -0400, Rudraksha Gupta wrote: > > Adds qcom,usb-hs-phy-msm8960 compatible > > > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > > --- > > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: resets: [[4294967295, 10], [1, 0]] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names:0: 'por' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names: ['phy', 'por'] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230604063032.365775-3-guptarud@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. I see. Why is it off the latest rc1 and not off the latest commit? > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. Thanks. I didn't see these errors as I was only looking for expressatt binding errors.
On Sun Jun 4, 2023 at 6:30 AM EDT, Krzysztof Kozlowski wrote: > On 04/06/2023 08:30, Rudraksha Gupta wrote: > > Adds qcom,usb-hs-phy-msm8960 compatible > > > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > > --- > > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > index aa97478dd016..63b6914993fe 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > > @@ -13,7 +13,9 @@ if: > > properties: > > compatible: > > contains: > > - const: qcom,usb-hs-phy-apq8064 > > + items: > > + - const: qcom,usb-hs-phy-apq8064 > > + - const: qcom,usb-hs-phy-msm8960 > > I have no clue what you want to achieve here. You break the bindings. When I added the USB node to the msm8960 dtsi file, I got similar messages for the expressatt/cdp that Rob mentioned in his email reply: phy: resets: [[25, 0]] is too short phy: reset-names:0: 'phy' was expected phy: reset-names: ['por'] is too short I will send an updated patch soon that addresses this. > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > Best regards, > Krzysztof Sorry. I was only looking for expressatt errors/warnings and failed to see the other errors/warnings in the sea of text.
On 06/06/2023 04:48, Rudraksha Gupta wrote: ted patch soon that addresses this. > >> >> It does not look like you tested the bindings, at least after quick >> look. Please run `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. >> >> Best regards, >> Krzysztof > Sorry. I was only looking for expressatt errors/warnings and failed to > see the other errors/warnings in the sea of text. https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index aa97478dd016..63b6914993fe 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -13,7 +13,9 @@ if: properties: compatible: contains: - const: qcom,usb-hs-phy-apq8064 + items: + - const: qcom,usb-hs-phy-apq8064 + - const: qcom,usb-hs-phy-msm8960 then: properties: resets: @@ -40,6 +42,7 @@ properties: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 - qcom,usb-hs-phy-msm8916 + - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 - const: qcom,usb-hs-phy
Adds qcom,usb-hs-phy-msm8960 compatible Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> --- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)