| Message ID | 20230612182527.3345786-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/adreno: make adreno_is_a690()'s argument const | expand |
On Mon, Jun 12, 2023 at 11:25 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > Change adreno_is_a690() prototype to accept the const struct adreno_gpu > pointer instead of a non-const one. This fixes the following warning: > > In file included from drivers/gpu/drm/msm/msm_drv.c:33: > drivers/gpu/drm/msm/adreno/adreno_gpu.h: In function ‘adreno_is_a660_family’: > drivers/gpu/drm/msm/adreno/adreno_gpu.h:303:54: warning: passing argument 1 of ‘adreno_is_a690’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > 303 | return adreno_is_a660(gpu) || adreno_is_a690(gpu) || adreno_is_7c3(gpu); > > Fixes: 1b90e8f8879c ("drm/msm/adreno: change adreno_is_* functions to accept const argument") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > index 1283e5fe22d2..9a7626c7ac4d 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > @@ -284,7 +284,7 @@ static inline int adreno_is_a660(const struct adreno_gpu *gpu) > return adreno_is_revn(gpu, 660); > } > > -static inline int adreno_is_a690(struct adreno_gpu *gpu) > +static inline int adreno_is_a690(const struct adreno_gpu *gpu) > { > return gpu->revn == 690; > }; > -- > 2.39.2 >
Hi, On Mon, Jun 12, 2023 at 11:25 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > Change adreno_is_a690() prototype to accept the const struct adreno_gpu > pointer instead of a non-const one. This fixes the following warning: > > In file included from drivers/gpu/drm/msm/msm_drv.c:33: > drivers/gpu/drm/msm/adreno/adreno_gpu.h: In function ‘adreno_is_a660_family’: > drivers/gpu/drm/msm/adreno/adreno_gpu.h:303:54: warning: passing argument 1 of ‘adreno_is_a690’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > 303 | return adreno_is_a660(gpu) || adreno_is_a690(gpu) || adreno_is_7c3(gpu); > > Fixes: 1b90e8f8879c ("drm/msm/adreno: change adreno_is_* functions to accept const argument") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, 12 Jun 2023 21:25:27 +0300, Dmitry Baryshkov wrote: > Change adreno_is_a690() prototype to accept the const struct adreno_gpu > pointer instead of a non-const one. This fixes the following warning: > > In file included from drivers/gpu/drm/msm/msm_drv.c:33: > drivers/gpu/drm/msm/adreno/adreno_gpu.h: In function ‘adreno_is_a660_family’: > drivers/gpu/drm/msm/adreno/adreno_gpu.h:303:54: warning: passing argument 1 of ‘adreno_is_a690’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > 303 | return adreno_is_a660(gpu) || adreno_is_a690(gpu) || adreno_is_7c3(gpu); > > [...] Applied, thanks! [1/1] drm/msm/adreno: make adreno_is_a690()'s argument const https://gitlab.freedesktop.org/lumag/msm/-/commit/b263325b4f34 Best regards,
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index 1283e5fe22d2..9a7626c7ac4d 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -284,7 +284,7 @@ static inline int adreno_is_a660(const struct adreno_gpu *gpu) return adreno_is_revn(gpu, 660); } -static inline int adreno_is_a690(struct adreno_gpu *gpu) +static inline int adreno_is_a690(const struct adreno_gpu *gpu) { return gpu->revn == 690; };
Change adreno_is_a690() prototype to accept the const struct adreno_gpu pointer instead of a non-const one. This fixes the following warning: In file included from drivers/gpu/drm/msm/msm_drv.c:33: drivers/gpu/drm/msm/adreno/adreno_gpu.h: In function ‘adreno_is_a660_family’: drivers/gpu/drm/msm/adreno/adreno_gpu.h:303:54: warning: passing argument 1 of ‘adreno_is_a690’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 303 | return adreno_is_a660(gpu) || adreno_is_a690(gpu) || adreno_is_7c3(gpu); Fixes: 1b90e8f8879c ("drm/msm/adreno: change adreno_is_* functions to accept const argument") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)