| Message ID | 20230620-topic-dsiphy_rpm-v1-1-446a7fd0ce43@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | DSIPHY RPM | expand |
On 20/06/2023 14:29, Konrad Dybcio wrote: > This helper has been introduced to avoid programmer errors when using > pm_runtime_get, use it. Please expand to mention the error kind. Also as you are at it, could you please add an error check here? > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index 9d5795c58a98..0a8e1dd4509e 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -516,7 +516,7 @@ static int dsi_phy_enable_resource(struct msm_dsi_phy *phy) > struct device *dev = &phy->pdev->dev; > int ret; > > - pm_runtime_get_sync(dev); > + pm_runtime_resume_and_get(dev); > > ret = clk_prepare_enable(phy->ahb_clk); > if (ret) { >
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 9d5795c58a98..0a8e1dd4509e 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -516,7 +516,7 @@ static int dsi_phy_enable_resource(struct msm_dsi_phy *phy) struct device *dev = &phy->pdev->dev; int ret; - pm_runtime_get_sync(dev); + pm_runtime_resume_and_get(dev); ret = clk_prepare_enable(phy->ahb_clk); if (ret) {
This helper has been introduced to avoid programmer errors when using pm_runtime_get, use it. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)