| Message ID | 20230623013731.1088007-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] drm/msm/dpu: fix DSC 1.2 block lengths | expand |
On 2023-06-23 04:37:31, Dmitry Baryshkov wrote: > Both struct dpu_dsc_sub_blks instances declare enc subblock length to be > 0x100, while the actual length is 0x9c (last register having offset 0x98). > Reduce subblock length to remove the empty register space from being > dumped. > > Fixes: 0d1b10c63346 ("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 0de507d4d7b7..dd2f89ada043 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -517,12 +517,12 @@ static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = { > * DSC sub blocks config > *************************************************************/ > static const struct dpu_dsc_sub_blks dsc_sblk_0 = { > - .enc = {.base = 0x100, .len = 0x100}, > + .enc = {.base = 0x100, .len = 0x9c}, > .ctl = {.base = 0xF00, .len = 0x10}, Hmm, these hexadecimals are still uppercase. When do we get a formatter/linter that automatically catches and fixes these? - Marijn > }; > > static const struct dpu_dsc_sub_blks dsc_sblk_1 = { > - .enc = {.base = 0x200, .len = 0x100}, > + .enc = {.base = 0x200, .len = 0x9c}, > .ctl = {.base = 0xF80, .len = 0x10}, > }; > > -- > 2.39.2 >
On 6/22/2023 6:37 PM, Dmitry Baryshkov wrote: > Both struct dpu_dsc_sub_blks instances declare enc subblock length to be > 0x100, while the actual length is 0x9c (last register having offset 0x98). > Reduce subblock length to remove the empty register space from being > dumped. > > Fixes: 0d1b10c63346 ("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 0de507d4d7b7..dd2f89ada043 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -517,12 +517,12 @@ static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = { * DSC sub blocks config *************************************************************/ static const struct dpu_dsc_sub_blks dsc_sblk_0 = { - .enc = {.base = 0x100, .len = 0x100}, + .enc = {.base = 0x100, .len = 0x9c}, .ctl = {.base = 0xF00, .len = 0x10}, }; static const struct dpu_dsc_sub_blks dsc_sblk_1 = { - .enc = {.base = 0x200, .len = 0x100}, + .enc = {.base = 0x200, .len = 0x9c}, .ctl = {.base = 0xF80, .len = 0x10}, };
Both struct dpu_dsc_sub_blks instances declare enc subblock length to be 0x100, while the actual length is 0x9c (last register having offset 0x98). Reduce subblock length to remove the empty register space from being dumped. Fixes: 0d1b10c63346 ("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)