| Message ID | 20230705053914.9759-2-quic_kbajaj@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | arm64: dts: qcom: qdu1000: Update reserved memory region | expand |
On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: > > Add missing reserved regions as described in QDU1000 memory map. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > index 1d22f87fd238..3f5512ec0a90 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > @@ -448,6 +448,32 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&reserved_memory{ > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ no_underscores_in_node_names. Ever. Also, if you have checked other platforms, you'd have seen that other platforms use a much more generic node name for 'memory' nodes (which you should have used too). > + no-map; > + reg = <0x0 0xe0000000 0x0 0x20000000>; > + }; > + > + harq_buffer_mem:harq_buffer_region@800000000{ > + no-map; > + reg = <0x8 0x0 0x0 0x80000000>; > + }; > + > + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ > + no-map; > + reg = <0x8 0x80000000 0x0 0x50000000>; > + }; > + > + fapi_buffer_mem:fapi_buffer_region@8d0000000{ > + no-map; > + reg = <0x8 0xd0000000 0x0 0x20000000>; > + }; > +}; > + > &sdhc { > pinctrl-0 = <&sdc_on_state>; > pinctrl-1 = <&sdc_off_state>; > -- > 2.40.1 >
On 05/07/2023 07:39, Komal Bajaj wrote: > Add missing reserved regions as described in QDU1000 memory map. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > index 1d22f87fd238..3f5512ec0a90 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > @@ -448,6 +448,32 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&reserved_memory{ > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; Drop, you should not neeed it. > + > + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ That's not correct style. Missing space after ':', no underscores in node names. reg is first property, not second. Please open existing files and look how it is done there. Srsly, just open qdu1000.dtsi which you are extending. Best regards, Krzysztof
On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >> Add missing reserved regions as described in QDU1000 memory map. >> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> index 1d22f87fd238..3f5512ec0a90 100644 >> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> @@ -448,6 +448,32 @@ &qupv3_id_0 { >> status = "okay"; >> }; >> >> +&reserved_memory{ >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ > no_underscores_in_node_names. Ever. > > Also, if you have checked other platforms, you'd have seen that other > platforms use a much more generic node name for 'memory' nodes (which > you should have used too). These memory nodes are new to QDU platform, so will it be okay if I keep these names without region suffix? Thanks Komal > >> + no-map; >> + reg = <0x0 0xe0000000 0x0 0x20000000>; >> + }; >> + >> + harq_buffer_mem:harq_buffer_region@800000000{ >> + no-map; >> + reg = <0x8 0x0 0x0 0x80000000>; >> + }; >> + >> + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ >> + no-map; >> + reg = <0x8 0x80000000 0x0 0x50000000>; >> + }; >> + >> + fapi_buffer_mem:fapi_buffer_region@8d0000000{ >> + no-map; >> + reg = <0x8 0xd0000000 0x0 0x20000000>; >> + }; >> +}; >> + >> &sdhc { >> pinctrl-0 = <&sdc_on_state>; >> pinctrl-1 = <&sdc_off_state>; >> -- >> 2.40.1 >> >
On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: > > > > On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: > > On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: > >> Add missing reserved regions as described in QDU1000 memory map. > >> > >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > >> --- > >> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ > >> 1 file changed, 26 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > >> index 1d22f87fd238..3f5512ec0a90 100644 > >> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > >> @@ -448,6 +448,32 @@ &qupv3_id_0 { > >> status = "okay"; > >> }; > >> > >> +&reserved_memory{ > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + > >> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ > > no_underscores_in_node_names. Ever. > > > > Also, if you have checked other platforms, you'd have seen that other > > platforms use a much more generic node name for 'memory' nodes (which > > you should have used too). > > These memory nodes are new to QDU platform, so will it be okay if I keep > these names without region suffix? Just use 'memory@abcd'. > > Thanks > Komal > > > > >> + no-map; > >> + reg = <0x0 0xe0000000 0x0 0x20000000>; > >> + }; > >> + > >> + harq_buffer_mem:harq_buffer_region@800000000{ > >> + no-map; > >> + reg = <0x8 0x0 0x0 0x80000000>; > >> + }; > >> + > >> + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ > >> + no-map; > >> + reg = <0x8 0x80000000 0x0 0x50000000>; > >> + }; > >> + > >> + fapi_buffer_mem:fapi_buffer_region@8d0000000{ > >> + no-map; > >> + reg = <0x8 0xd0000000 0x0 0x20000000>; > >> + }; > >> +}; > >> + > >> &sdhc { > >> pinctrl-0 = <&sdc_on_state>; > >> pinctrl-1 = <&sdc_off_state>; > >> -- > >> 2.40.1 > >> > > >
On 7/5/2023 3:12 PM, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >> >> >> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: >>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >>>> Add missing reserved regions as described in QDU1000 memory map. >>>> >>>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> index 1d22f87fd238..3f5512ec0a90 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> @@ -448,6 +448,32 @@ &qupv3_id_0 { >>>> status = "okay"; >>>> }; >>>> >>>> +&reserved_memory{ >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + ranges; >>>> + >>>> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ >>> no_underscores_in_node_names. Ever. >>> >>> Also, if you have checked other platforms, you'd have seen that other >>> platforms use a much more generic node name for 'memory' nodes (which >>> you should have used too). >> These memory nodes are new to QDU platform, so will it be okay if I keep >> these names without region suffix? > Just use 'memory@abcd'. Sure, will update like that. > >> Thanks >> Komal >> >>>> + no-map; >>>> + reg = <0x0 0xe0000000 0x0 0x20000000>; >>>> + }; >>>> + >>>> + harq_buffer_mem:harq_buffer_region@800000000{ >>>> + no-map; >>>> + reg = <0x8 0x0 0x0 0x80000000>; >>>> + }; >>>> + >>>> + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ >>>> + no-map; >>>> + reg = <0x8 0x80000000 0x0 0x50000000>; >>>> + }; >>>> + >>>> + fapi_buffer_mem:fapi_buffer_region@8d0000000{ >>>> + no-map; >>>> + reg = <0x8 0xd0000000 0x0 0x20000000>; >>>> + }; >>>> +}; >>>> + >>>> &sdhc { >>>> pinctrl-0 = <&sdc_on_state>; >>>> pinctrl-1 = <&sdc_off_state>; >>>> -- >>>> 2.40.1 >>>> >
On 5.07.2023 11:42, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >> >> >> >> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: >>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >>>> Add missing reserved regions as described in QDU1000 memory map. >>>> >>>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> index 1d22f87fd238..3f5512ec0a90 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>> @@ -448,6 +448,32 @@ &qupv3_id_0 { >>>> status = "okay"; >>>> }; >>>> >>>> +&reserved_memory{ >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + ranges; >>>> + >>>> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ >>> no_underscores_in_node_names. Ever. >>> >>> Also, if you have checked other platforms, you'd have seen that other >>> platforms use a much more generic node name for 'memory' nodes (which >>> you should have used too). >> >> These memory nodes are new to QDU platform, so will it be okay if I keep >> these names without region suffix? > > Just use 'memory@abcd'. Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml Following the generic-names recommended practice, node names should reflect the purpose of the node (ie. "framebuffer" or "dma-pool"). Unit address (@<address>) should be appended to the name if the node is a static allocation. Konrad > >> >> Thanks >> Komal >> >>> >>>> + no-map; >>>> + reg = <0x0 0xe0000000 0x0 0x20000000>; >>>> + }; >>>> + >>>> + harq_buffer_mem:harq_buffer_region@800000000{ >>>> + no-map; >>>> + reg = <0x8 0x0 0x0 0x80000000>; >>>> + }; >>>> + >>>> + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ >>>> + no-map; >>>> + reg = <0x8 0x80000000 0x0 0x50000000>; >>>> + }; >>>> + >>>> + fapi_buffer_mem:fapi_buffer_region@8d0000000{ >>>> + no-map; >>>> + reg = <0x8 0xd0000000 0x0 0x20000000>; >>>> + }; >>>> +}; >>>> + >>>> &sdhc { >>>> pinctrl-0 = <&sdc_on_state>; >>>> pinctrl-1 = <&sdc_off_state>; >>>> -- >>>> 2.40.1 >>>> >>> >> > >
On 05/07/2023 13:08, Konrad Dybcio wrote: > On 5.07.2023 11:42, Dmitry Baryshkov wrote: >> On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >>> >>> >>> >>> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote: >>>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >>>>> Add missing reserved regions as described in QDU1000 memory map. >>>>> >>>>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >>>>> --- >>>>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ >>>>> 1 file changed, 26 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>>> index 1d22f87fd238..3f5512ec0a90 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>>>> @@ -448,6 +448,32 @@ &qupv3_id_0 { >>>>> status = "okay"; >>>>> }; >>>>> >>>>> +&reserved_memory{ >>>>> + #address-cells = <2>; >>>>> + #size-cells = <2>; >>>>> + ranges; >>>>> + >>>>> + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ >>>> no_underscores_in_node_names. Ever. >>>> >>>> Also, if you have checked other platforms, you'd have seen that other >>>> platforms use a much more generic node name for 'memory' nodes (which >>>> you should have used too). >>> >>> These memory nodes are new to QDU platform, so will it be okay if I keep >>> these names without region suffix? >> >> Just use 'memory@abcd'. > Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml > > Following the generic-names recommended practice, node names should > reflect the purpose of the node (ie. "framebuffer" or "dma-pool"). > Unit address (@<address>) should be appended to the name if the node > is a static allocation. > Yeah, two minutes too late :) Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts index 1d22f87fd238..3f5512ec0a90 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts @@ -448,6 +448,32 @@ &qupv3_id_0 { status = "okay"; }; +&reserved_memory{ + #address-cells = <2>; + #size-cells = <2>; + ranges; + + ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{ + no-map; + reg = <0x0 0xe0000000 0x0 0x20000000>; + }; + + harq_buffer_mem:harq_buffer_region@800000000{ + no-map; + reg = <0x8 0x0 0x0 0x80000000>; + }; + + tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{ + no-map; + reg = <0x8 0x80000000 0x0 0x50000000>; + }; + + fapi_buffer_mem:fapi_buffer_region@8d0000000{ + no-map; + reg = <0x8 0xd0000000 0x0 0x20000000>; + }; +}; + &sdhc { pinctrl-0 = <&sdc_on_state>; pinctrl-1 = <&sdc_off_state>;
Add missing reserved regions as described in QDU1000 memory map. Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> --- arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++ 1 file changed, 26 insertions(+) -- 2.40.1