| Message ID | 20230712130215.666924-1-amit.pundir@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: display/msm: qcom,sdm845-mdss: add memory-region property | expand |
On 12/07/2023 16:02, Amit Pundir wrote: > Add and document the reserved memory region property > in the qcom,sdm845-mdss schema. > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > --- > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > index 6ecb00920d7f..3ea1dbd7e317 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > @@ -39,6 +39,11 @@ properties: > interconnect-names: > maxItems: 2 > > + memory-region: > + maxItems: 1 > + description: > + Phandle to a node describing a reserved memory region. > + Please add it to mdss-common.yaml instead > patternProperties: > "^display-controller@[0-9a-f]+$": > type: object
On 12/07/2023 15:02, Amit Pundir wrote: > Add and document the reserved memory region property > in the qcom,sdm845-mdss schema. > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> Please keep consistent versioning, so this is new patch in v4. > --- > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > index 6ecb00920d7f..3ea1dbd7e317 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > @@ -39,6 +39,11 @@ properties: > interconnect-names: > maxItems: 2 > > + memory-region: > + maxItems: 1 > + description: > + Phandle to a node describing a reserved memory region. Your description says nothing new. It's entirely redundant/obvious. Instead please describe what reserved memory is expected to be here. Best regards, Krzysztof
On Wed, 12 Jul 2023 at 18:45, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On 12/07/2023 16:02, Amit Pundir wrote: > > Add and document the reserved memory region property > > in the qcom,sdm845-mdss schema. > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > --- > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > @@ -39,6 +39,11 @@ properties: > > interconnect-names: > > maxItems: 2 > > > > + memory-region: > > + maxItems: 1 > > + description: > > + Phandle to a node describing a reserved memory region. > > + > > Please add it to mdss-common.yaml instead mdss-common.yaml didn't like this property at all and I ran into a lot of new dtbs_check warnings: https://www.irccloud.com/pastebin/raw/pEYAeaB1 I need some help in decoding these please. Regards, Amit Pundir > > > patternProperties: > > "^display-controller@[0-9a-f]+$": > > type: object > > -- > With best wishes > Dmitry >
On Wed, 12 Jul 2023 at 19:46, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 12/07/2023 15:02, Amit Pundir wrote: > > Add and document the reserved memory region property > > in the qcom,sdm845-mdss schema. > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > Please keep consistent versioning, so this is new patch in v4. ACK. > > > --- > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > @@ -39,6 +39,11 @@ properties: > > interconnect-names: > > maxItems: 2 > > > > + memory-region: > > + maxItems: 1 > > + description: > > + Phandle to a node describing a reserved memory region. > > Your description says nothing new. It's entirely redundant/obvious. > Instead please describe what reserved memory is expected to be here. On it. I'll update in v5. Thanks. Regards, Amit Pundir > > > Best regards, > Krzysztof >
On Thu, 13 Jul 2023 at 18:34, Amit Pundir <amit.pundir@linaro.org> wrote: > > On Wed, 12 Jul 2023 at 18:45, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On 12/07/2023 16:02, Amit Pundir wrote: > > > Add and document the reserved memory region property > > > in the qcom,sdm845-mdss schema. > > > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > > --- > > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > @@ -39,6 +39,11 @@ properties: > > > interconnect-names: > > > maxItems: 2 > > > > > > + memory-region: > > > + maxItems: 1 > > > + description: > > > + Phandle to a node describing a reserved memory region. > > > + > > > > Please add it to mdss-common.yaml instead > > mdss-common.yaml didn't like this property at all and > I ran into a lot of new dtbs_check warnings: > https://www.irccloud.com/pastebin/raw/pEYAeaB1 > > I need some help in decoding these please. I'm not sure what happened there (and it's hard to understand without seeing your patch). But after applying your patch to mdss-common.yaml, `make dt_binding_check' passes: diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml index ccd7d6417523..924fe383e4a1 100644 --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml @@ -77,6 +77,11 @@ properties: items: - description: MDSS_CORE reset + memory-region: + maxItems: 1 + description: + Phandle to a node describing a reserved memory region. + required: - reg - reg-names > > Regards, > Amit Pundir > > > > > > patternProperties: > > > "^display-controller@[0-9a-f]+$": > > > type: object > > > > -- > > With best wishes > > Dmitry > >
On Thu, 13 Jul 2023 at 21:13, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Thu, 13 Jul 2023 at 18:34, Amit Pundir <amit.pundir@linaro.org> wrote: > > > > On Wed, 12 Jul 2023 at 18:45, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > On 12/07/2023 16:02, Amit Pundir wrote: > > > > Add and document the reserved memory region property > > > > in the qcom,sdm845-mdss schema. > > > > > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > > > --- > > > > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > > index 6ecb00920d7f..3ea1dbd7e317 100644 > > > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml > > > > @@ -39,6 +39,11 @@ properties: > > > > interconnect-names: > > > > maxItems: 2 > > > > > > > > + memory-region: > > > > + maxItems: 1 > > > > + description: > > > > + Phandle to a node describing a reserved memory region. > > > > + > > > > > > Please add it to mdss-common.yaml instead > > > > mdss-common.yaml didn't like this property at all and > > I ran into a lot of new dtbs_check warnings: > > https://www.irccloud.com/pastebin/raw/pEYAeaB1 > > > > I need some help in decoding these please. > > I'm not sure what happened there (and it's hard to understand without > seeing your patch). Yup.. It was my broken patch. I used "For example:" in the property description and it tripped off the checks. Didn't realise that casually used ":" can break yaml parsing until now. Sorry for all the noise. Regards, Amit Pundir > But after applying your patch to mdss-common.yaml, > `make dt_binding_check' passes: > > diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > index ccd7d6417523..924fe383e4a1 100644 > --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml > @@ -77,6 +77,11 @@ properties: > items: > - description: MDSS_CORE reset > > + memory-region: > + maxItems: 1 > + description: > + Phandle to a node describing a reserved memory region. > + > required: > - reg > - reg-names > > > > > > Regards, > > Amit Pundir > > > > > > > > > patternProperties: > > > > "^display-controller@[0-9a-f]+$": > > > > type: object > > > > > > -- > > > With best wishes > > > Dmitry > > > > > > > -- > With best wishes > Dmitry
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml index 6ecb00920d7f..3ea1dbd7e317 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml @@ -39,6 +39,11 @@ properties: interconnect-names: maxItems: 2 + memory-region: + maxItems: 1 + description: + Phandle to a node describing a reserved memory region. + patternProperties: "^display-controller@[0-9a-f]+$": type: object
Add and document the reserved memory region property in the qcom,sdm845-mdss schema. Signed-off-by: Amit Pundir <amit.pundir@linaro.org> --- .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 5 +++++ 1 file changed, 5 insertions(+)