diff mbox series

[v2,02/15] dt-bindings: opp: Increase maxItems for opp-hz property

Message ID 20230720054100.9940-3-manivannan.sadhasivam@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series UFS: Add OPP and interconnect support | expand

Commit Message

Manivannan Sadhasivam July 20, 2023, 5:40 a.m. UTC
Current limit of 16 will be exhausted by platforms specifying the frequency
for 9 clocks using opp-hz, like Qcom SDM845 SoC. For instance, specifying
the frequency for 9 clocks with 64bit specifier as below would consume
(9 * 2 = 18) items.

	opp-50000000 {
		opp-hz = /bits/ 64 <50000000>,
			 /bits/ 64 <0>,
			 /bits/ 64 <0>,
			 /bits/ 64 <37500000>,
			 /bits/ 64 <0>,
			 /bits/ 64 <0>,
			 /bits/ 64 <0>,
			 /bits/ 64 <0>,
			 /bits/ 64 <75000000>;
	};

So let's increase the limit to 32 which should be enough for most platforms
(hopefully).

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring July 24, 2023, 3:51 p.m. UTC | #1
On Thu, 20 Jul 2023 11:10:47 +0530, Manivannan Sadhasivam wrote:
> Current limit of 16 will be exhausted by platforms specifying the frequency
> for 9 clocks using opp-hz, like Qcom SDM845 SoC. For instance, specifying
> the frequency for 9 clocks with 64bit specifier as below would consume
> (9 * 2 = 18) items.
> 
> 	opp-50000000 {
> 		opp-hz = /bits/ 64 <50000000>,
> 			 /bits/ 64 <0>,
> 			 /bits/ 64 <0>,
> 			 /bits/ 64 <37500000>,
> 			 /bits/ 64 <0>,
> 			 /bits/ 64 <0>,
> 			 /bits/ 64 <0>,
> 			 /bits/ 64 <0>,
> 			 /bits/ 64 <75000000>;
> 	};
> 
> So let's increase the limit to 32 which should be enough for most platforms
> (hopefully).
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Viresh Kumar July 25, 2023, 4:11 a.m. UTC | #2
On 24-07-23, 09:51, Rob Herring wrote:
> 
> On Thu, 20 Jul 2023 11:10:47 +0530, Manivannan Sadhasivam wrote:
> > Current limit of 16 will be exhausted by platforms specifying the frequency
> > for 9 clocks using opp-hz, like Qcom SDM845 SoC. For instance, specifying
> > the frequency for 9 clocks with 64bit specifier as below would consume
> > (9 * 2 = 18) items.
> > 
> > 	opp-50000000 {
> > 		opp-hz = /bits/ 64 <50000000>,
> > 			 /bits/ 64 <0>,
> > 			 /bits/ 64 <0>,
> > 			 /bits/ 64 <37500000>,
> > 			 /bits/ 64 <0>,
> > 			 /bits/ 64 <0>,
> > 			 /bits/ 64 <0>,
> > 			 /bits/ 64 <0>,
> > 			 /bits/ 64 <75000000>;
> > 	};
> > 
> > So let's increase the limit to 32 which should be enough for most platforms
> > (hopefully).
> > 
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> Acked-by: Rob Herring <robh@kernel.org>

Applied. Thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
index 47e6f36b7637..e2f8f7af3cf4 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
@@ -56,7 +56,7 @@  patternProperties:
           need to be configured and that is left for the implementation
           specific binding.
         minItems: 1
-        maxItems: 16
+        maxItems: 32
         items:
           maxItems: 1