diff mbox series

[1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings

Message ID 20230802175628.1.I7a950de49ec24b957e90d7fe7abd5f2f5f2e24c3@changeid (mailing list archive)
State Superseded
Headers show
Series Add no-esim sku for sc7180-lazor family and new board version | expand

Commit Message

Sheng-Liang Pan Aug. 2, 2023, 9:57 a.m. UTC 
Introduce more sc7180-lazor sku and board version configuration,
add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
add new board version 10 for audio codec ALC5682i-VS.

Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
---

 .../devicetree/bindings/arm/qcom.yaml         | 43 ++++++++++++++++---
 1 file changed, 38 insertions(+), 5 deletions(-)

Comments

Doug Anderson Aug. 2, 2023, 8:53 p.m. UTC | #1 
Hi,

On Wed, Aug 2, 2023 at 2:58 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> Introduce more sc7180-lazor sku and board version configuration,
> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> add new board version 10 for audio codec ALC5682i-VS.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
>  .../devicetree/bindings/arm/qcom.yaml         | 43 ++++++++++++++++---
>  1 file changed, 38 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..e0efc80a72e1 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -460,7 +460,7 @@ properties:
>            - const: google,lazor-rev2
>            - const: qcom,sc7180
>
> -      - description: Acer Chromebook Spin 513 (rev3 - 8)
> +      - description: Acer Chromebook Spin 513 (rev3 - 9)
>          items:
>            - const: google,lazor-rev3
>            - const: google,lazor-rev4
> @@ -468,6 +468,7 @@ properties:
>            - const: google,lazor-rev6
>            - const: google,lazor-rev7
>            - const: google,lazor-rev8
> +          - const: google,lazor-rev9

I don't think this is correct. lazor-rev9 has the Parade bridge chip,
not the TI bridge chip. It can't be lumped together with the earlier
revisions. What you want to do is leave the "rev3 - 8" alone, then add
a new entry just for "-rev9". Your brand new revision 10 doesn't need
its own entry in this list because it's the "newest rev".



> @@ -550,6 +565,24 @@ properties:
>            - const: google,lazor-sku6
>            - const: qcom,sc7180
>
> +      - description: Acer Chromebook 511 no-esim (rev9)
> +        items:
> +          - const: google,lazor-rev9-sku15
> +          - const: qcom,sc7180
> +
> +      - description: Acer Chromebook 511 no-esim(newest rev)

nit: please put a space before "(newest rev)"


> +        items:
> +          - const: google,lazor-sku15

You're missing the second item: "const: qcom,sc7180"


> +      - description: Acer Chromebook 511 without Touchscreen no-esim (rev9)
> +        items:
> +          - const: google,lazor-rev9-sku18
> +          - const: qcom,sc7180
> +
> +      - description: Acer Chromebook 511 without Touchscreen no-esim(newest rev)

nit: please put a space before "(newest rev)"


> +        items:
> +          - const: google,lazor-sku18

You're missing the second item: "const: qcom,sc7180"
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..e0efc80a72e1 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -460,7 +460,7 @@  properties:
           - const: google,lazor-rev2
           - const: qcom,sc7180
 
-      - description: Acer Chromebook Spin 513 (rev3 - 8)
+      - description: Acer Chromebook Spin 513 (rev3 - 9)
         items:
           - const: google,lazor-rev3
           - const: google,lazor-rev4
@@ -468,6 +468,7 @@  properties:
           - const: google,lazor-rev6
           - const: google,lazor-rev7
           - const: google,lazor-rev8
+          - const: google,lazor-rev9
           - const: qcom,sc7180
 
       - description: Acer Chromebook Spin 513 (newest rev)
@@ -481,7 +482,7 @@  properties:
           - const: google,lazor-rev2-sku2
           - const: qcom,sc7180
 
-      - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
+      - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 9)
         items:
           - const: google,lazor-rev3-sku2
           - const: google,lazor-rev4-sku2
@@ -489,6 +490,7 @@  properties:
           - const: google,lazor-rev6-sku2
           - const: google,lazor-rev7-sku2
           - const: google,lazor-rev8-sku2
+          - const: google,lazor-rev9-sku2
           - const: qcom,sc7180
 
       - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
@@ -502,7 +504,7 @@  properties:
           - const: google,lazor-rev2-sku0
           - const: qcom,sc7180
 
-      - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
+      - description: Acer Chromebook Spin 513 with LTE (rev3 - 9)
         items:
           - const: google,lazor-rev3-sku0
           - const: google,lazor-rev4-sku0
@@ -510,6 +512,7 @@  properties:
           - const: google,lazor-rev6-sku0
           - const: google,lazor-rev7-sku0
           - const: google,lazor-rev8-sku0
+          - const: google,lazor-rev9-sku0
           - const: qcom,sc7180
 
       - description: Acer Chromebook Spin 513 with LTE (newest rev)
@@ -517,13 +520,24 @@  properties:
           - const: google,lazor-sku0
           - const: qcom,sc7180
 
-      - description: Acer Chromebook 511 (rev4 - rev8)
+      - description: Acer Chromebook Spin 513 with LTE no-esim (rev9)
+        items:
+          - const: google,lazor-rev9-sku10
+          - const: qcom,sc7180
+
+      - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev)
+        items:
+          - const: google,lazor-sku10
+          - const: qcom,sc7180
+
+      - description: Acer Chromebook 511 (rev4 - rev9)
         items:
           - const: google,lazor-rev4-sku4
           - const: google,lazor-rev5-sku4
           - const: google,lazor-rev6-sku4
           - const: google,lazor-rev7-sku4
           - const: google,lazor-rev8-sku4
+          - const: google,lazor-rev9-sku4
           - const: qcom,sc7180
 
       - description: Acer Chromebook 511 (newest rev)
@@ -536,13 +550,14 @@  properties:
           - const: google,lazor-rev4-sku5
           - const: qcom,sc7180
 
-      - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
+      - description: Acer Chromebook 511 without Touchscreen (rev5 - rev9)
         items:
           - const: google,lazor-rev5-sku5
           - const: google,lazor-rev5-sku6
           - const: google,lazor-rev6-sku6
           - const: google,lazor-rev7-sku6
           - const: google,lazor-rev8-sku6
+          - const: google,lazor-rev9-sku6
           - const: qcom,sc7180
 
       - description: Acer Chromebook 511 without Touchscreen (newest rev)
@@ -550,6 +565,24 @@  properties:
           - const: google,lazor-sku6
           - const: qcom,sc7180
 
+      - description: Acer Chromebook 511 no-esim (rev9)
+        items:
+          - const: google,lazor-rev9-sku15
+          - const: qcom,sc7180
+
+      - description: Acer Chromebook 511 no-esim(newest rev)
+        items:
+          - const: google,lazor-sku15
+
+      - description: Acer Chromebook 511 without Touchscreen no-esim (rev9)
+        items:
+          - const: google,lazor-rev9-sku18
+          - const: qcom,sc7180
+
+      - description: Acer Chromebook 511 without Touchscreen no-esim(newest rev)
+        items:
+          - const: google,lazor-sku18
+
       - description: Google Mrbland with AUO panel (rev0)
         items:
           - const: google,mrbland-rev0-sku0