| Message ID | 20230809120432.1036405-8-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | apq8016: camss: Update dts with various fixes | expand |
On 9.08.2023 14:04, Bryan O'Donoghue wrote: > When we have no camera mezzanine attached it is still possible to run the > test-pattern generator of the CSID block. Wasn't it broken? [...] > > +&camss { > + status = "okay"; > + ports { Again, please add a newline if there's gonna be a resend. Konrad
On 09/08/2023 13:11, Konrad Dybcio wrote: > On 9.08.2023 14:04, Bryan O'Donoghue wrote: >> When we have no camera mezzanine attached it is still possible to run the >> test-pattern generator of the CSID block. > Wasn't it broken? > > [...] > So, running the TPG without the mezzaine has always been possible but, with the hard-coded sensor you'd fail to probe and never get user-space enumeration. The fix is moving the sensor portion to its own mezzanine and enabling camss standalone. I'll make that clearer in the log for V2. Thx for the review. --- bod
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts index 84641925f3329..46cbeaa2f2acc 100644 --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts @@ -250,6 +250,15 @@ &blsp_uart2 { label = "LS-UART1"; }; +&camss { + status = "okay"; + ports { + port@0 { + reg = <0>; + }; + }; +}; + &lpass { status = "okay"; };
When we have no camera mezzanine attached it is still possible to run the test-pattern generator of the CSID block. As an example: media-ctl --reset yavta --no-query -w '0x009f0903 1' /dev/v4l-subdev2 yavta --list /dev/v4l-subdev2 media-ctl -d /dev/media0 -V '"msm_csid0":0[fmt:UYVY8_1X16/1920x1080 field:none]' media-ctl -l '"msm_csid0":1->"msm_ispif0":0[1]' media-ctl -d /dev/media0 -V '"msm_ispif0":0[fmt:UYVY8_1X16/1920x1080 field:none]' media-ctl -l '"msm_ispif0":1->"msm_vfe0_rdi0":0[1]' media-ctl -d /dev/media0 -V '"msm_vfe0_rdi0":0[fmt:UYVY8_1X16/1920x1080]' media-ctl -d /dev/media0 -p yavta -B capture-mplane --capture=5 -n 5 -I -f UYVY -s 1920x1080 --file=TPG-UYVU-1920x1080-000-#.bin /dev/video0 Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 9 +++++++++ 1 file changed, 9 insertions(+)