diff mbox series

[v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply

Message ID 20230816060502.16789-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Headers show
Series [v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply | expand

Commit Message

Krzysztof Kozlowski Aug. 16, 2023, 6:05 a.m. UTC 
Bluetooth requires VDDIO supply and Doug Anderson suggested it is
vreg_l18b_1p8.  Add one to satisfy `dtbs_check`:

  sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Use vreg_l18b_1p8 (Doug). Due to such change, don't add Rb tag.
---
 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Doug Anderson Aug. 16, 2023, 10:29 p.m. UTC | #1 
Hi,

On Tue, Aug 15, 2023 at 11:05 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bluetooth requires VDDIO supply and Doug Anderson suggested it is
> vreg_l18b_1p8.  Add one to satisfy `dtbs_check`:
>
>   sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes in v2:
> 1. Use vreg_l18b_1p8 (Doug). Due to such change, don't add Rb tag.
> ---
>  arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 4 ++++
>  1 file changed, 4 insertions(+)

Right. Previous discussion was at:

https://lore.kernel.org/r/CAD=FV=UMqrAU9cLy3Ew5o1MJyNDAAG2TY1mvMkY2-8kiw6qpjg@mail.gmail.com

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Bjorn Andersson Sept. 20, 2023, 2:14 a.m. UTC | #2 
On Wed, 16 Aug 2023 08:05:02 +0200, Krzysztof Kozlowski wrote:
> Bluetooth requires VDDIO supply and Doug Anderson suggested it is
> vreg_l18b_1p8.  Add one to satisfy `dtbs_check`:
> 
>   sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply
      commit: b9a2ee03019609f580ac5cae8211371119025909

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
index afae7f46b050..c2cba9d7179b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
@@ -38,6 +38,10 @@  vreg_s1k_1p0: smps1 {
 	};
 };
 
+&bluetooth {
+	vddio-supply = <&vreg_l18b_1p8>;
+};
+
 ap_tp_i2c: &i2c0 {
 	status = "okay";
 	clock-frequency = <400000>;