diff mbox series

[-next] clk: qcom: gcc-ipq5018: change some variable static

Message ID 20230816080113.1222352-1-yangyingliang@huawei.com (mailing list archive)
State Accepted
Headers show
Series [-next] clk: qcom: gcc-ipq5018: change some variable static | expand

Commit Message

Yang Yingliang Aug. 16, 2023, 8:01 a.m. UTC
lpass_axim_clk_src and lpass_sway_clk_src are only
used in gcc-ipq5018.c now, change them to static.

Fixes: e3fdbef1bab8 ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/clk/qcom/gcc-ipq5018.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Konrad Dybcio Aug. 16, 2023, 11:42 a.m. UTC | #1
On 16.08.2023 10:01, Yang Yingliang wrote:
> lpass_axim_clk_src and lpass_sway_clk_src are only
> used in gcc-ipq5018.c now, change them to static.
> 
> Fixes: e3fdbef1bab8 ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Dmitry Baryshkov Aug. 30, 2023, 8:16 p.m. UTC | #2
On Wed, 16 Aug 2023 at 11:05, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> lpass_axim_clk_src and lpass_sway_clk_src are only
> used in gcc-ipq5018.c now, change them to static.
>
> Fixes: e3fdbef1bab8 ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>  drivers/clk/qcom/gcc-ipq5018.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5018.c b/drivers/clk/qcom/gcc-ipq5018.c
> index 313ff2281ca7..19dc2b71cacf 100644
> --- a/drivers/clk/qcom/gcc-ipq5018.c
> +++ b/drivers/clk/qcom/gcc-ipq5018.c
> @@ -826,7 +826,7 @@ static const struct freq_tbl ftbl_lpass_axim_clk_src[] = {
>         { }
>  };
>
> -struct clk_rcg2 lpass_axim_clk_src = {
> +static struct clk_rcg2 lpass_axim_clk_src = {
>         .cmd_rcgr = 0x2e028,
>         .freq_tbl = ftbl_lpass_axim_clk_src,
>         .hid_width = 5,
> @@ -844,7 +844,7 @@ static const struct freq_tbl ftbl_lpass_sway_clk_src[] = {
>         { }
>  };
>
> -struct clk_rcg2 lpass_sway_clk_src = {
> +static struct clk_rcg2 lpass_sway_clk_src = {
>         .cmd_rcgr = 0x2e040,
>         .freq_tbl = ftbl_lpass_sway_clk_src,
>         .hid_width = 5,
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-ipq5018.c b/drivers/clk/qcom/gcc-ipq5018.c
index 313ff2281ca7..19dc2b71cacf 100644
--- a/drivers/clk/qcom/gcc-ipq5018.c
+++ b/drivers/clk/qcom/gcc-ipq5018.c
@@ -826,7 +826,7 @@  static const struct freq_tbl ftbl_lpass_axim_clk_src[] = {
 	{ }
 };
 
-struct clk_rcg2 lpass_axim_clk_src = {
+static struct clk_rcg2 lpass_axim_clk_src = {
 	.cmd_rcgr = 0x2e028,
 	.freq_tbl = ftbl_lpass_axim_clk_src,
 	.hid_width = 5,
@@ -844,7 +844,7 @@  static const struct freq_tbl ftbl_lpass_sway_clk_src[] = {
 	{ }
 };
 
-struct clk_rcg2 lpass_sway_clk_src = {
+static struct clk_rcg2 lpass_sway_clk_src = {
 	.cmd_rcgr = 0x2e040,
 	.freq_tbl = ftbl_lpass_sway_clk_src,
 	.hid_width = 5,