| Message ID | 20230905-sc7180-adsp-rproc-v1-2-dfea7699da7b@trvn.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sc7180: Add ADSP | expand |
On 5.09.2023 07:47, Nikita Travkin wrote: > sc7180 has a dedicated ADSP similar to the one found in sm8250. > Add it's compatible to the driver reusing the existing config so > the devices that use the adsp can probe it. > > Signed-off-by: Nikita Travkin <nikita@trvn.ru> > --- > drivers/remoteproc/qcom_q6v5_pas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index b5447dd2dd35..55fafc68200e 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -1161,6 +1161,7 @@ static const struct of_device_id adsp_of_match[] = { > { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init }, > { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, > { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, > + { .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource}, Should we use a fallback here, maybe? Konrad
Konrad Dybcio писал(а) 05.09.2023 13:35: > On 5.09.2023 07:47, Nikita Travkin wrote: >> sc7180 has a dedicated ADSP similar to the one found in sm8250. >> Add it's compatible to the driver reusing the existing config so >> the devices that use the adsp can probe it. >> >> Signed-off-by: Nikita Travkin <nikita@trvn.ru> >> --- >> drivers/remoteproc/qcom_q6v5_pas.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c >> index b5447dd2dd35..55fafc68200e 100644 >> --- a/drivers/remoteproc/qcom_q6v5_pas.c >> +++ b/drivers/remoteproc/qcom_q6v5_pas.c >> @@ -1161,6 +1161,7 @@ static const struct of_device_id adsp_of_match[] = { >> { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init }, >> { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, >> { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, >> + { .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource}, > Should we use a fallback here, maybe? > Not sure if it makes sense to, given afaiu no other soc defines two compatibles for the adsp right now... > Konrad
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index b5447dd2dd35..55fafc68200e 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -1161,6 +1161,7 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init }, { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, + { .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource}, { .compatible = "qcom,sc7180-mpss-pas", .data = &mpss_resource_init}, { .compatible = "qcom,sc7280-mpss-pas", .data = &mpss_resource_init}, { .compatible = "qcom,sc8180x-adsp-pas", .data = &sm8150_adsp_resource},
sc7180 has a dedicated ADSP similar to the one found in sm8250. Add it's compatible to the driver reusing the existing config so the devices that use the adsp can probe it. Signed-off-by: Nikita Travkin <nikita@trvn.ru> --- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+)