diff mbox series

[v2,3/4] arm64: dts: qcom: sc7180: Add tertiary mi2s pinctrl

Message ID 20230905-sc7180-adsp-rproc-v2-3-8ab7f299600a@trvn.ru (mailing list archive)
State Superseded
Headers show
Series sc7180: Add ADSP | expand

Commit Message

Nikita Travkin Sept. 5, 2023, 10:41 a.m. UTC
Some devices use tertiary mi2s to connect external audio codec.
Add it near the other two i2s pinctrl definitions so the devices don't
have to duplicate it.

Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Nikita Travkin Sept. 5, 2023, 4:19 p.m. UTC | #1
Konrad Dybcio писал(а) 05.09.2023 20:53:
> On 5.09.2023 12:41, Nikita Travkin wrote:
>> Some devices use tertiary mi2s to connect external audio codec.
>> Add it near the other two i2s pinctrl definitions so the devices don't
>> have to duplicate it.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> ---
> This sorting makes no sense, neither alphabetically nor gpio-idx-wise
> 
> I'd suggest chucking it in after pri_mi2s_mclk_active.
> 

I assumed these are alphabetically sorted since other nodes before mostly
are, with the pri_* being an outlier, but I can move it below if you think
it would be better.

Nikita

> Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index a79c0f2e1879..9f68b5ff0030 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2033,6 +2033,11 @@  sec_mi2s_active: sec-mi2s-active-state {
 				function = "mi2s_1";
 			};
 
+			ter_mi2s_active: ter-mi2s-active-state {
+				pins = "gpio63", "gpio64", "gpio65", "gpio66";
+				function = "mi2s_2";
+			};
+
 			pri_mi2s_active: pri-mi2s-active-state {
 				pins = "gpio53", "gpio54", "gpio55", "gpio56";
 				function = "mi2s_0";