| Message ID | 20230905161920.252013-6-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cda965bc05128aaa58826d93af92f2bb186c0015 |
| Headers | show |
| Series | arm64: dts: qcom: correct UFS pad supply | expand |
On 5.09.2023 18:19, Krzysztof Kozlowski wrote: > The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. > Eventually the old driver was removed in commit 02dca8c981b5 ("phy: > qcom: remove ufs qmp phy driver"). The original driver and its binding > used vddp-ref-clk regulator supply, but the new one did not and left the > supply unused. > > The Qualcomm UFS phy bindings were also migrated to newer ones and > dropped support for vddp-ref-clk regulator in commit dc5cb63592bd > ("dt-bindings: phy: migrate QMP UFS PHY bindings to > qcom,sc8280xp-qmp-ufs-phy.yaml"). > > It turns out that this regulator, although with inaccurate name > vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or > similar, depending on the SoC) used by UFS controller. > > Bring back handling of this supply by using more appropriate regulator - > UFS controller host supply. This also fixes dtbs_check warning: > > apq8096-db820c.dtb: phy@627000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts index 385b178314db..d2aaff3e0d02 100644 --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts @@ -1091,7 +1091,6 @@ &ufsphy { vdda-phy-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; - vddp-ref-clk-supply = <&vreg_l25a_1p2>; }; &ufshc { @@ -1100,6 +1099,7 @@ &ufshc { vcc-supply = <&vreg_l20a_2p95>; vccq-supply = <&vreg_l25a_1p2>; vccq2-supply = <&vreg_s4a_1p8>; + vdd-hba-supply = <&vreg_l25a_1p2>; vcc-max-microamp = <600000>; vccq-max-microamp = <450000>;
The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: apq8096-db820c.dtb: phy@627000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)