| Message ID | 20231010-caleb-rb2-host-mode-v1-1-b057d443cd62@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: qrb4210-rb2: don't force usb peripheral mode | expand |
On 10/10/2023 11:46, Caleb Connolly wrote: > The rb2 only has a single USB controller, it can be switched between a > type-c port and an internal USB hub via a DIP switch. Until dynamic > role switching is available it's preferable to put the USB controller > in host mode so that the type-A ports and ethernet are available. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > base-commit: 6465e260f48790807eef06b583b38ca9789b6072 > > // Caleb (they/them) > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index a7278a9472ed..9738c0dacd58 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -518,7 +518,6 @@ &usb { > > &usb_dwc3 { > maximum-speed = "super-speed"; > - dr_mode = "peripheral"; > }; > > &usb_hsphy { > No fixes tag ? Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 10/10/23 12:46, Caleb Connolly wrote: > The rb2 only has a single USB controller, it can be switched between a > type-c port and an internal USB hub via a DIP switch. Until dynamic > role switching is available it's preferable to put the USB controller > in host mode so that the type-A ports and ethernet are available. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- Fixes: eaa53a85748d ("arm64: dts: qcom: qrb4210-rb2: Enable USB node") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 10/10/23 13:46, Caleb Connolly wrote: > The rb2 only has a single USB controller, it can be switched between a > type-c port and an internal USB hub via a DIP switch. Until dynamic > role switching is available it's preferable to put the USB controller > in host mode so that the type-A ports and ethernet are available. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > base-commit: 6465e260f48790807eef06b583b38ca9789b6072 > > // Caleb (they/them) > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index a7278a9472ed..9738c0dacd58 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -518,7 +518,6 @@ &usb { > > &usb_dwc3 { > maximum-speed = "super-speed"; > - dr_mode = "peripheral"; > }; > > &usb_hsphy { > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> Thank you for the fix! -- Best wishes, Vladimir
On Tue, Oct 10, 2023 at 11:46:58AM +0100, Caleb Connolly wrote: > The rb2 only has a single USB controller, it can be switched between a > type-c port and an internal USB hub via a DIP switch. Until dynamic > role switching is available it's preferable to put the USB controller > in host mode so that the type-A ports and ethernet are available. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> Applied, thanks. > --- > base-commit: 6465e260f48790807eef06b583b38ca9789b6072 > > // Caleb (they/them) > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index a7278a9472ed..9738c0dacd58 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -518,7 +518,6 @@ &usb { > > &usb_dwc3 { > maximum-speed = "super-speed"; > - dr_mode = "peripheral"; > }; > > &usb_hsphy { >
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts index a7278a9472ed..9738c0dacd58 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -518,7 +518,6 @@ &usb { &usb_dwc3 { maximum-speed = "super-speed"; - dr_mode = "peripheral"; }; &usb_hsphy {
The rb2 only has a single USB controller, it can be switched between a type-c port and an internal USB hub via a DIP switch. Until dynamic role switching is available it's preferable to put the USB controller in host mode so that the type-A ports and ethernet are available. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- base-commit: 6465e260f48790807eef06b583b38ca9789b6072 // Caleb (they/them) --- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 1 - 1 file changed, 1 deletion(-)