| Message ID | 20231012072051.1517826-1-alessandro.carminati@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | scsi: ufs: core: Fix build error: ufshcd_opp_config_clks | expand |
On Thu, Oct 12, 2023 at 07:20:51AM +0000, Alessandro Carminati (Red Hat) wrote: > Building linux-6.6-rc3 with this patchset applied and the following > configuration: > > CONFIG_SCSI_UFSHCD=m > CONFIG_SCSI_UFS_BSG=y > > I got: > > scripts/mod/modpost -M -m -a -o Module.symvers -T modules.order vmlinux.o > ERROR: modpost: "ufshcd_opp_config_clks" [drivers/ufs/host/ufshcd-pltfrm.ko] undefined! > make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1 > make[1]: *** [/home/alessandro/src/linux-6.6-rc3/Makefile:1865: modpost] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 > > I needed to add an export symbol to have the build complete > > Signed-off-by: Alessandro Carminati (Red Hat) <alessandro.carminati@gmail.com> Thanks for the diff. I will squash it with the offending patch. - Mani > --- > drivers/ufs/core/ufshcd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index ccd7fcd18355..c0631c37c3d1 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -1098,6 +1098,7 @@ int ufshcd_opp_config_clks(struct device *dev, struct opp_table *opp_table, > > return 0; > } > +EXPORT_SYMBOL_GPL(ufshcd_opp_config_clks); > > static int ufshcd_opp_set_rate(struct ufs_hba *hba, unsigned long freq) > { > -- > 2.34.1 >
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index ccd7fcd18355..c0631c37c3d1 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -1098,6 +1098,7 @@ int ufshcd_opp_config_clks(struct device *dev, struct opp_table *opp_table, return 0; } +EXPORT_SYMBOL_GPL(ufshcd_opp_config_clks); static int ufshcd_opp_set_rate(struct ufs_hba *hba, unsigned long freq) {
Building linux-6.6-rc3 with this patchset applied and the following configuration: CONFIG_SCSI_UFSHCD=m CONFIG_SCSI_UFS_BSG=y I got: scripts/mod/modpost -M -m -a -o Module.symvers -T modules.order vmlinux.o ERROR: modpost: "ufshcd_opp_config_clks" [drivers/ufs/host/ufshcd-pltfrm.ko] undefined! make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1 make[1]: *** [/home/alessandro/src/linux-6.6-rc3/Makefile:1865: modpost] Error 2 make: *** [Makefile:234: __sub-make] Error 2 I needed to add an export symbol to have the build complete Signed-off-by: Alessandro Carminati (Red Hat) <alessandro.carminati@gmail.com> --- drivers/ufs/core/ufshcd.c | 1 + 1 file changed, 1 insertion(+)