| Message ID | 20231016-nia-sm8350-for-upstream-v1-2-bb557a0af2e9@igalia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | support oneplus-lemonade(p) devices | expand |
On 10/16/23 14:47, Nia Espera wrote: > DMA0 node downstream is specified at 0x900000, so fix the typo. Without > this, enabling any i2c node using DMA0 causes a hang. > > Signed-off-by: Nia Espera <nespera@igalia.com> > --- Oh hmm.. I wonder if that's why I could never get one of the i2c hosts on 8350 to behave.. Fixes: bc08fbf49bc8 ("arm64: dts: qcom: sm8350: Define GPI DMA engines") Fixes: 41d6bca799b3 ("arm64: dts: qcom: sm8350: correct DMA controller unit address") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 10/17/23 17:44, Konrad Dybcio wrote: > > > On 10/16/23 14:47, Nia Espera wrote: >> DMA0 node downstream is specified at 0x900000, so fix the typo. Without >> this, enabling any i2c node using DMA0 causes a hang. >> >> Signed-off-by: Nia Espera <nespera@igalia.com> >> --- > Oh hmm.. I wonder if that's why I could never get one of the i2c hosts > on 8350 to behave.. Unfortunately, it doesn't fix quite everything. It takes the device from instantly breaking to booting and then spitting an error, though, so that's nice at least - and even then only sometimes. Probably missing clocks, but I've had it properly initialize once or twice at least. > > Fixes: bc08fbf49bc8 ("arm64: dts: qcom: sm8350: Define GPI DMA engines") > Fixes: 41d6bca799b3 ("arm64: dts: qcom: sm8350: correct DMA controller > unit address") > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 00604bf7724f..6d12066389fa 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -918,9 +918,9 @@ spi19: spi@894000 { }; }; - gpi_dma0: dma-controller@9800000 { + gpi_dma0: dma-controller@900000 { compatible = "qcom,sm8350-gpi-dma", "qcom,sm6350-gpi-dma"; - reg = <0 0x09800000 0 0x60000>; + reg = <0 0x00900000 0 0x60000>; interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>,
DMA0 node downstream is specified at 0x900000, so fix the typo. Without this, enabling any i2c node using DMA0 causes a hang. Signed-off-by: Nia Espera <nespera@igalia.com> --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)