| Message ID | 20231016200415.791090-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/a6xx: add QMP dependency | expand |
On 10/16/23 22:04, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When QMP is in a loadable module, the A6xx GPU driver fails to link > as built-in: > > x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': > a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' > > Add the usual dependency that still allows compiling without QMP but > otherwise avoids the broken combination of options. > > Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Right, thanks! Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 16/10/2023 23:04, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When QMP is in a loadable module, the A6xx GPU driver fails to link > as built-in: > > x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': > a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' > > Add the usual dependency that still allows compiling without QMP but > otherwise avoids the broken combination of options. > > Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, 16 Oct 2023 22:04:03 +0200, Arnd Bergmann wrote: > When QMP is in a loadable module, the A6xx GPU driver fails to link > as built-in: > > x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume': > a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send' > > Add the usual dependency that still allows compiling without QMP but > otherwise avoids the broken combination of options. > > [...] Applied, thanks! [1/1] drm/msm/a6xx: add QMP dependency https://gitlab.freedesktop.org/lumag/msm/-/commit/96ab215b2d5e Best regards,
diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 6309a857ca312..ad70b611b44f0 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -6,6 +6,7 @@ config DRM_MSM depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST depends on COMMON_CLK depends on IOMMU_SUPPORT + depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n depends on QCOM_OCMEM || QCOM_OCMEM=n depends on QCOM_LLCC || QCOM_LLCC=n depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n