| Message ID | 20231024154338.407191-6-dsankouski@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | None | expand |
On 24/10/2023 16:43, Dzmitry Sankouski wrote: > Disable the crypto block due to it causing an SError in qce_start() on > the starqltechn, which happens upon every boot when cryptomanager tests are > enabled. > > Same problem is on Lenovo C630, see > commit 382e3e0eb6a8 ("arm64: dts: qcom: c630: disable crypto due to serror") > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > Link: https://lore.kernel.org/r/20211105035235.2392-1-steev@kali.org > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Konrad Dybcio <konrad.dybcio@linaro.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > > --- > > Changes in v2: > - none > > arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > index f2bc3c412a2f..0e2c7df2baa7 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > @@ -504,6 +504,11 @@ touchscreen@48 { > }; > }; > > +&crypto { > + /* FIXME: qce_start triggers an SError */ > + status = "disable"; > +}; > + > /* Modem/wifi*/ > &mss_pil { > status = "okay"; Probably another patch that should have Fixes. BTW when you do "git send-email" please include a "--to=someone@adomain.xyz" your emails appear with a weird red box that declares "(no To-header on input)<>" in Thunderbird - I guess because you didn't do "git send-email --to=" For preference I do "--to=" for everybody who appears as a maintainer/supporter and "--cc=" to the named mailing lists with myself last. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- bod
On 10/24/23 17:43, Dzmitry Sankouski wrote: > Disable the crypto block due to it causing an SError in qce_start() on > the starqltechn, which happens upon every boot when cryptomanager tests are > enabled. > > Same problem is on Lenovo C630, see > commit 382e3e0eb6a8 ("arm64: dts: qcom: c630: disable crypto due to serror") Would that still happen with this change: diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c index b9243c0aa626..dd1a2b679098 100644 --- a/drivers/interconnect/qcom/sdm845.c +++ b/drivers/interconnect/qcom/sdm845.c @@ -1805,7 +1805,7 @@ static struct platform_driver qnoc_driver = { .driver = { .name = "qnoc-sdm845", .of_match_table = qnoc_of_match, - .sync_state = icc_sync_state, +// .sync_state = icc_sync_state, }, }; module_platform_driver(qnoc_driver); ? Konrad
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts index f2bc3c412a2f..0e2c7df2baa7 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts @@ -504,6 +504,11 @@ touchscreen@48 { }; }; +&crypto { + /* FIXME: qce_start triggers an SError */ + status = "disable"; +}; + /* Modem/wifi*/ &mss_pil { status = "okay";
Disable the crypto block due to it causing an SError in qce_start() on the starqltechn, which happens upon every boot when cryptomanager tests are enabled. Same problem is on Lenovo C630, see commit 382e3e0eb6a8 ("arm64: dts: qcom: c630: disable crypto due to serror") Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> Link: https://lore.kernel.org/r/20211105035235.2392-1-steev@kali.org Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <andersson@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Konrad Dybcio <konrad.dybcio@linaro.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org --- Changes in v2: - none arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 5 +++++ 1 file changed, 5 insertions(+)