From patchwork Sun Oct 29 16:57:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Otto_Pfl=C3=BCger?= X-Patchwork-Id: 13439832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630C5C4332F for ; Sun, 29 Oct 2023 16:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbjJ2Q6E (ORCPT ); Sun, 29 Oct 2023 12:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjJ2Q6C (ORCPT ); Sun, 29 Oct 2023 12:58:02 -0400 Received: from srv01.abscue.de (abscue.de [IPv6:2a03:4000:63:bf5:4817:8eff:feeb:8ac7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AABEC2 for ; Sun, 29 Oct 2023 09:57:54 -0700 (PDT) Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id 9CE301C258E; Sun, 29 Oct 2023 17:57:51 +0100 (CET) Received: from fluffy-mammal.fritz.box (dslb-088-078-198-137.088.078.pools.vodafone-ip.de [88.78.198.137]) by srv01.abscue.de (Postfix) with ESMTPSA id 3E6821C2590; Sun, 29 Oct 2023 17:57:51 +0100 (CET) From: =?utf-8?q?Otto_Pfl=C3=BCger?= To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , linux-sound@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Otto_Pfl=C3=BCger?= Subject: [PATCH v2 1/4] ASoC: qcom: q6core: expose ADSP core firmware version Date: Sun, 29 Oct 2023 17:57:13 +0100 Message-Id: <20231029165716.69878-2-otto.pflueger@abscue.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231029165716.69878-1-otto.pflueger@abscue.de> References: <20231029165716.69878-1-otto.pflueger@abscue.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add a q6core_get_adsp_version() function that returns the version of the ADSP firmware (2.6, 2.7 or 2.8), also known as the AVS version (see [1] in downstream kernel). Some APIs differ between these versions, e.g. the AFE clock APIs. [1]: https://github.com/msm8916-mainline/linux-downstream/blob/LA.BR.1.2.9.1_rb1.5/sound/soc/msm/qdsp6v2/q6core.c#L193 Signed-off-by: Otto Pflüger --- sound/soc/qcom/qdsp6/q6core.c | 65 +++++++++++++++++++++++++++++++++++ sound/soc/qcom/qdsp6/q6core.h | 9 +++++ 2 files changed, 74 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6core.c b/sound/soc/qcom/qdsp6/q6core.c index 49cfb32cd209..855ab4ff1e59 100644 --- a/sound/soc/qcom/qdsp6/q6core.c +++ b/sound/soc/qcom/qdsp6/q6core.c @@ -20,6 +20,9 @@ #define AVCS_CMDRSP_ADSP_EVENT_GET_STATE 0x0001290D #define AVCS_GET_VERSIONS 0x00012905 #define AVCS_GET_VERSIONS_RSP 0x00012906 +#define AVCS_CMDRSP_Q6_ID_2_6 0x00040000 +#define AVCS_CMDRSP_Q6_ID_2_7 0x00040001 +#define AVCS_CMDRSP_Q6_ID_2_8 0x00040002 #define AVCS_CMD_GET_FWK_VERSION 0x001292c #define AVCS_CMDRSP_GET_FWK_VERSION 0x001292d @@ -63,6 +66,7 @@ struct q6core { bool get_state_supported; bool get_version_supported; bool is_version_requested; + enum q6core_version adsp_version; }; static struct q6core *g_core; @@ -108,6 +112,14 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) if (!core->fwk_version) return -ENOMEM; + /* + * Since GET_VERSIONS is not called when GET_FWK_VERSION + * is successful and these commands may return completely + * different versions, assume that the version is 2.8 here. + * Older versions do not support GET_FWK_VERSION and we do + * not care if the version is newer than 2.8. + */ + core->adsp_version = Q6_ADSP_VERSION_2_8; core->fwk_version_supported = true; core->resp_received = true; @@ -115,6 +127,7 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) } case AVCS_GET_VERSIONS_RSP: { struct avcs_cmdrsp_get_version *v; + int i; v = data->payload; @@ -125,6 +138,32 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) if (!core->svc_version) return -ENOMEM; + for (i = 0; i < g_core->svc_version->num_services; i++) { + struct avcs_svc_info *info; + + info = &g_core->svc_version->svc_api_info[i]; + if (info->service_id != APR_SVC_ADSP_CORE) + continue; + + switch (info->version) { + case AVCS_CMDRSP_Q6_ID_2_6: + core->adsp_version = Q6_ADSP_VERSION_2_6; + break; + case AVCS_CMDRSP_Q6_ID_2_7: + core->adsp_version = Q6_ADSP_VERSION_2_7; + break; + case AVCS_CMDRSP_Q6_ID_2_8: + core->adsp_version = Q6_ADSP_VERSION_2_8; + break; + default: + dev_err(&adev->dev, "Unknown AVS version 0x%08x\n", + info->version); + break; + } + + break; + } + core->get_version_supported = true; core->resp_received = true; @@ -293,6 +332,31 @@ int q6core_get_svc_api_info(int svc_id, struct q6core_svc_api_info *ainfo) } EXPORT_SYMBOL_GPL(q6core_get_svc_api_info); +/** + * q6core_get_adsp_version() - Get the core version number. + * + * Return: version code or Q6_ADSP_VERSION_UNKNOWN on failure + */ +enum q6core_version q6core_get_adsp_version(void) +{ + int ret; + + if (!g_core) + return Q6_ADSP_VERSION_UNKNOWN; + + mutex_lock(&g_core->lock); + if (!g_core->is_version_requested) { + if (q6core_get_fwk_versions(g_core) == -ENOTSUPP) + q6core_get_svc_versions(g_core); + g_core->is_version_requested = true; + } + ret = g_core->adsp_version; + mutex_unlock(&g_core->lock); + + return ret; +} +EXPORT_SYMBOL_GPL(q6core_get_adsp_version); + /** * q6core_is_adsp_ready() - Get status of adsp * @@ -334,6 +398,7 @@ static int q6core_probe(struct apr_device *adev) dev_set_drvdata(&adev->dev, g_core); mutex_init(&g_core->lock); + g_core->adsp_version = Q6_ADSP_VERSION_UNKNOWN; g_core->adev = adev; init_waitqueue_head(&g_core->wait); return 0; diff --git a/sound/soc/qcom/qdsp6/q6core.h b/sound/soc/qcom/qdsp6/q6core.h index 4105b1d730be..472e06bf8efc 100644 --- a/sound/soc/qcom/qdsp6/q6core.h +++ b/sound/soc/qcom/qdsp6/q6core.h @@ -9,7 +9,16 @@ struct q6core_svc_api_info { uint32_t api_branch_version; }; +/* Versions must be in order! */ +enum q6core_version { + Q6_ADSP_VERSION_UNKNOWN, + Q6_ADSP_VERSION_2_6, + Q6_ADSP_VERSION_2_7, + Q6_ADSP_VERSION_2_8, +}; + bool q6core_is_adsp_ready(void); +enum q6core_version q6core_get_adsp_version(void); int q6core_get_svc_api_info(int svc_id, struct q6core_svc_api_info *ainfo); #endif /* __Q6CORE_H__ */