| Message ID | 20231103163434.2.I11f77956d2492c88aca0ef5462123f225caf4fb4@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered | expand |
On Fri, Nov 03, 2023 at 04:34:28PM -0700, Douglas Anderson wrote: > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > interrupt should be configured as edge triggered. Make the change. > > Fixes: 0e51f883daa9 ("arm64: dts: qcom: sc7280: Add APSS watchdog node") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 04bf85b0399a..1964ef66492f 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -5389,7 +5389,7 @@ watchdog: watchdog@17c10000 { > compatible = "qcom,apss-wdt-sc7280", "qcom,kpss-wdt"; > reg = <0 0x17c10000 0 0x1000>; > clocks = <&sleep_clk>; > - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; > status = "reserved"; /* Owned by Gunyah hyp */ > }; > > -- > 2.42.0.869.gea05f2083d-goog >
Quoting Douglas Anderson (2023-11-03 16:34:28) > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > interrupt should be configured as edge triggered. Make the change. > > Fixes: 0e51f883daa9 ("arm64: dts: qcom: sc7280: Add APSS watchdog node") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 04bf85b0399a..1964ef66492f 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -5389,7 +5389,7 @@ watchdog: watchdog@17c10000 { compatible = "qcom,apss-wdt-sc7280", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; status = "reserved"; /* Owned by Gunyah hyp */ };
As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 0e51f883daa9 ("arm64: dts: qcom: sc7280: Add APSS watchdog node") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)