diff mbox series

arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources

Message ID 20231106-wakeup-source-v1-1-36b1f39e67fd@kali.org (mailing list archive)
State Superseded
Headers show
Series arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources | expand

Commit Message

Steev Klimaszewski via B4 Relay Nov. 7, 2023, 12:12 a.m. UTC 
From: Steev Klimaszewski <steev@kali.org>

The keyboard, touchpad and touchscreen can all be used to wake the
computer up from sleep, so mark them as such in the dts file.

Signed-off-by: Steev Klimaszewski <steev@kali.org>
---
It would be nice to wake up the Lenovo Yoga C630 from suspend by hitting
the keyboard or touchpad or even touchscreen, so this patch enables that
ability.

I'm not married to enabling it for the touchscreen, so if anyone wants
me to drop that hunk, I'd be fine with it.
---
 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++++++
 1 file changed, 8 insertions(+)


---
base-commit: 3ff7a5781ceee3befb9224d29cef6e6a4766c5fe
change-id: 20231106-wakeup-source-15af6f5a6329

Best regards,

Comments

Konrad Dybcio Nov. 7, 2023, 9:26 p.m. UTC | #1 
On 11/7/23 01:12, Steev Klimaszewski via B4 Relay wrote:
> From: Steev Klimaszewski <steev@kali.org>
> 
> The keyboard, touchpad and touchscreen can all be used to wake the
> computer up from sleep, so mark them as such in the dts file.
> 
> Signed-off-by: Steev Klimaszewski <steev@kali.org>
> ---
> It would be nice to wake up the Lenovo Yoga C630 from suspend by hitting
> the keyboard or touchpad or even touchscreen, so this patch enables that
> ability.
> 
> I'm not married to enabling it for the touchscreen, so if anyone wants
> me to drop that hunk, I'd be fine with it.
Does the touchscreen power off? Would touching it when the laptop is
asleep wake the device up? If so, I'd say that leaving it out makes
more sense by default

Konrad
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 92a812b5f423..9ddffb98408d 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -384,6 +384,8 @@  tsel: hid@15 {
 		hid-descr-addr = <0x1>;
 
 		interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
+
+		wakeup-source;
 	};
 
 	tsc2: hid@2c {
@@ -392,6 +394,8 @@  tsc2: hid@2c {
 		hid-descr-addr = <0x20>;
 
 		interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
+
+		wakeup-source;
 	};
 };
 
@@ -408,6 +412,8 @@  tsc1: hid@10 {
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&i2c5_hid_active>;
+
+		wakeup-source;
 	};
 };
 
@@ -482,6 +488,8 @@  ecsh: hid@5c {
 
 		pinctrl-names = "default";
 		pinctrl-0 = <&i2c11_hid_active>;
+
+		wakeup-source;
 	};
 };